Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install overwrites custom rancher-system-agent.env file #101

Open
agracey opened this issue Nov 23, 2022 · 2 comments
Open

Install overwrites custom rancher-system-agent.env file #101

agracey opened this issue Nov 23, 2022 · 2 comments

Comments

@agracey
Copy link

agracey commented Nov 23, 2022

It appears that the installer is overwriting the .env file at
https://github.com/rancher/system-agent/blob/main/install.sh#L804

This is causing issues with a few users who are behind a corporate proxy. Is there a way to set a proxy to be used when defining a cluster?

@Oats87
Copy link
Collaborator

Oats87 commented Dec 29, 2022

The expectation is that proxies required by the node are defined by the user shell/service shell, and are set in a global location on the node. If the user has the corresponding HTTP_PROXY etc. environment variables set, they should be set for the system agent.

@Oats87
Copy link
Collaborator

Oats87 commented Dec 29, 2022

It's important to note that Rancher doesn't really support communication-through-proxy in the first place, due to potential performance implications. We don't want to open WATCH requests through a corporate proxy for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants