Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make imagePullPolicy configurable via values #66

Open
gnoling opened this issue Feb 14, 2024 · 3 comments
Open

Make imagePullPolicy configurable via values #66

gnoling opened this issue Feb 14, 2024 · 3 comments

Comments

@gnoling
Copy link

gnoling commented Feb 14, 2024

Is your feature request related to a problem? Please describe.
In an airgapped environment, an imagePullPolicy of "always" is not ideal. Currently, the following templates hard-code this value:

https://github.com/rancher/vsphere-charts/blob/main/charts/rancher-vsphere-csi/templates/controller/deployment.yaml#L127

https://github.com/rancher/vsphere-charts/blob/main/charts/rancher-vsphere-csi/templates/node/daemonset.yaml#L100

Describe the solution you'd like
This value should be configurable in the chart values, such as "Never".

@Mart-Kuc
Copy link

Hi @gnoling, this issue is resolved in this PR

@HoustonDad
Copy link

@Mart-Kuc Thanks for the link! Any idea of when this might be released publicly?

@Mart-Kuc
Copy link

Mart-Kuc commented Nov 4, 2024

Hi @HoustonDad I'm not the maintainer of this repository, so I don't have that information. What I do know is that the PR was merged into the upstream repository, but I’m not sure about the release date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants