Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add injectedReducers property to a store #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xprazak2
Copy link

Adding the injectedReducers property to a store can cause problems when testing connected components using snapshots.

When adding a new reducer, each snapshots will need to be regenerated because the injectedReducers property on injected store changes. This will become painful as an application grows.

If we want to expose the injectedReducers to the outside world, I can add a function to a store that does it for us.

Let me know what you think.

@ares
Copy link

ares commented Nov 13, 2017

what's the status here?

@xprazak2
Copy link
Author

waiting for review

@ares
Copy link

ares commented Nov 13, 2017

@randallknutson would you mind taking a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants