Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused QRect when drawing slider gutter #17

Open
JulienMaille opened this issue Nov 7, 2020 · 0 comments · May be fixed by #20
Open

Unused QRect when drawing slider gutter #17

JulienMaille opened this issue Nov 7, 2020 · 0 comments · May be fixed by #20

Comments

@JulienMaille
Copy link

JulienMaille commented Nov 7, 2020

if ((option->subControls & SC_SliderGroove) && groove.isValid()) {
QRect g0 = groove;
if (g0.height() > 5)
g0.adjust(0, 1, 0, -1);
Ph::PSave saver(painter);
Swatchy gutterColor =
option->state & State_Enabled ? S_scrollbarGutter : S_window;
Ph::paintBorderedRoundRect(painter, groove, Ph::SliderGroove_Rounding,
swatch, outlineColor, gutterColor);
}

g0 is adjusted but not used, did you plan to call

   Ph::paintBorderedRoundRect(painter, g0, Ph::SliderGroove_Rounding, 
                              swatch, outlineColor, gutterColor); 
JulienMaille added a commit to JulienMaille/phantomstyle that referenced this issue Nov 7, 2020
@JulienMaille JulienMaille linked a pull request Nov 7, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant