Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sixel: Text doesn't overwrite sixels #636

Closed
AnonymouX47 opened this issue Sep 2, 2024 · 4 comments
Closed

sixel: Text doesn't overwrite sixels #636

AnonymouX47 opened this issue Sep 2, 2024 · 4 comments

Comments

@AnonymouX47
Copy link

I just tested it out the sixel support...

First, kudos for the work. 👍

Just one observation so far... text doesn't overwrite sixels, which I believe is opposite to the standard behaviour, as in:

Screenshot_2024-09-02_08-35-06

This is unlike several other terminal emulators. Also, this means the only way to clear sixels off the screen is by actually clearing the whole screen which isn't very practical. This might not seem like a problem to users who only "cat out" images on a scrolling screen but this behaviour makes the feature difficult/impossible to use in fullscreen applications (i.e. which don't scroll the screen). Below are shots from Xterm and WezTerm:

Xterm Wezterm
Screenshot_2024-09-02_08-35-40 Screenshot_2024-09-02_08-35-45

For what it's worth, I understand the work isn't finalized yet but I thought it was still worth noting.

Finally, I see iTerm2 IIP support is also underway. I'd like to note that the behaviour should be the same.

Thanks. 😃

Originally posted by @AnonymouX47 in #38 (comment)

@raphamorim
Copy link
Owner

Thank you for the issue! Will take a look on it

@raphamorim
Copy link
Owner

Pushed a fix for text overwrite in main, when you have time please test it 🙏
Screenshot 2024-09-05 at 18 47 40

@AnonymouX47
Copy link
Author

Tested and it works great! 🎉

I also tested EL (CSI K) and ECH (CSI X) and they erased sixels, as they should.

Thank you very much and well done! 😃

@github-project-automation github-project-automation bot moved this from In Progress to Done in Rio terminal 0.2.x Sep 6, 2024
@raphamorim
Copy link
Owner

Thank you for testing it @AnonymouX47 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants