Cannot modify visibility of private method?

[facboy]

Is the following not supposed to work (in an AgentBuilder)?

return dynamicTypeBuilder
        .method(methodMatcher)
        .intercept(SuperMethodCall.INSTANCE)
        .transform(Transformer.ForMethod.withModifiers(Visibility.PROTECTED));

It's a bit hard to follow but when debugging it is applied to the transformed MethodDescriptor but this is then added to a Prepared.Entry which has its own visibility field. The visibility field gets its value from the original methodDescriptor and ignores modifiers on the transformed MethodDescriptor.

[raphw]

Have a look at ModifierAdjustment which can be applied as a decorator (without defining an interception). I think that is what you actually want to do.

[facboy]

hmm...so at runtime, once adjusted, i can see that the modifier has changed, but it still doesn't do quite what i wanted, so i guess i'll ask another question:

is it possible to change a method from private to protected, and then have (existing) subclasses override that method?

[raphw]

That should be possible, yes. This does however assume that both methods have the same signature.

What are you observing?

[facboy]

I can see with reflection that the modifier is changed, but the calling methods just invoke the "previously private but now protected" method directly and ignore the overriding methods in the sub-classes.

[raphw]

I assume that the method is already linked. What happens when you retransform those classes without any changes? Christopher Ng ***@***.***> schrieb am So., 24. Nov. 2024, 11:58:

…

I can see with reflection that the modifier is changed, but the calling methods just invoke the "previously private but now protected" method directly and ignore the overriding methods in the sub-classes. — Reply to this email directly, view it on GitHub <#1728 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCIA4HLTIHNZZQFVKDGPWL2CGWNTAVCNFSM6AAAAABSJJVQ3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJVHEZTONJYGU> . You are receiving this because you were assigned.Message ID: ***@***.***>

[facboy]

hum, i tried recreating in an isolated test case and haven't been able to, so perhaps i've got some mismatch in the arguments or something somewhere. when you say already linked what do you mean? the classes are already loaded somehow? or?

[raphw]

For example: if a class path scanner looks for classes, this might trigger their loading.