Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer Overflow in com.rapidminer.operator.meta.ParameterIteration.java in 7.5+ #22

Open
s-j-v-zelst opened this issue Aug 29, 2017 · 0 comments

Comments

@s-j-v-zelst
Copy link

Dear RapidMiner team,

(I develop the RapidProM extension for RM).
I found a (severe) bug in the "Loop Parameters" operator

In my experiments (I'm a researcher) I use the "Loop Parameters" operator a lot (com.rapidminer.operator.meta.ParameterIteration.java).
I just found out that in the doWork() method, the actual number of combinations (int numberOfCombinations) is counted twice.
In case of a very large number of iterations (which tends to happen in large scale experiments), the variable reaches an overflow and becomes negative.
As a result I get a UserError related to the fact that no valid parameter combination can be generated, i.e.:

if (numberOfCombinations < 1 || values.length == 0) {
throw new UserError(this, 958);
}

I can see some ways how to fix this, however, since I'm not very familiar with the meaning of all variables within the operator I guess it is best if one of you guys fixs this.

cheers,

Bas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant