Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RAPIDS to CMake 3.30.4 as minimum required version #154

Open
11 of 12 tasks
robertmaynard opened this issue Feb 19, 2025 · 5 comments
Open
11 of 12 tasks

Update RAPIDS to CMake 3.30.4 as minimum required version #154

robertmaynard opened this issue Feb 19, 2025 · 5 comments
Assignees

Comments

@robertmaynard
Copy link

robertmaynard commented Feb 19, 2025

Description

Update all of RAPIDS to require CMake 3.30.4 as the minimum required version.

Benefits

This allows RAPIDS projects to use newer versions of CPM and removes
the numerous CMake policy warnings that each build of RAPIDS currently encounters.

Approach

Use rapids-reviser, update cmake_minimum_required contents in each project plus all CMake pins to =>3.30.4.

Tasks

@jameslamb
Copy link
Member

Thanks! I think we want these updates for a few more repos:

(GitHub search I used to find those)

@jameslamb
Copy link
Member

I went through and approved every non-draft PR that still needed a packaging-codeowners approval. The PRs will need some more nudging:

  • many also require approval from like a {project}-cmake-codeowners or {project}-build-codeowners group
  • some have unrelated CI issues

@jakirkham
Copy link
Member

Do we need to update CMake in the wheels CI image?

Am seeing errors like this one on CI:

CMake Error at CMakeLists.txt:16 (cmake_minimum_required):
  CMake 3.30.4 or higher is required.  You are running version 3.26.5

@gforsyth
Copy link

gforsyth commented Feb 19, 2025

Something else is going on there -- cmake is getting installed earlier in that workflow: https://github.com/rapidsai/cucim/actions/runs/13422360912/job/37498031392?pr=834#step:11:55

nevermind, that's for the python environment but there's a separate call to a shell script that probably doesn't have access to the updated cmake

@robertmaynard
Copy link
Author

Need to update rapids-cmake with a disable of CMP0169 to unblock all the PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants