From 063c950a41b8a54cd2473d7c491508cc17c57389 Mon Sep 17 00:00:00 2001 From: AJ Schmidt Date: Fri, 8 Sep 2023 15:41:26 -0400 Subject: [PATCH] Remove header tests From some internal Slack discussions, it was determined that the `headers_test.sh` file is no longer necessary. This PR removes it and its associated checks. --- .pre-commit-config.yaml | 12 -- ci/checks/headers_test.sh | 25 ---- conda/recipes/libcudf/meta.yaml | 249 -------------------------------- 3 files changed, 286 deletions(-) delete mode 100755 ci/checks/headers_test.sh diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index b5165cf026f..238e5b44030 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -128,18 +128,6 @@ repos: language: system pass_filenames: false verbose: true - - id: headers-recipe-check - name: headers-recipe-check - entry: ./ci/checks/headers_test.sh - files: | - (?x)^( - ^cpp/include/| - ^conda/.*/meta.yaml - ) - types_or: [file] - language: system - pass_filenames: false - verbose: false - repo: https://github.com/codespell-project/codespell rev: v2.2.2 hooks: diff --git a/ci/checks/headers_test.sh b/ci/checks/headers_test.sh deleted file mode 100755 index b859009a8c5..00000000000 --- a/ci/checks/headers_test.sh +++ /dev/null @@ -1,25 +0,0 @@ -#!/bin/bash -# Copyright (c) 2020-2022, NVIDIA CORPORATION. -##################################### -# conda existence test for headers # -##################################### - -RETVAL=0 -LIBNAME=cudf -DIRNAMES="cudf cudf_test" - -# existence tests for lib${LIBNAME} -for DIRNAME in ${DIRNAMES[@]}; do - HEADERS=`cd cpp && find include/${DIRNAME} -type f \( -iname "*.h" -o -iname "*.hpp" \) -print | sed 's|^| - test -f $PREFIX/|' | sort` - META_TESTS=`grep -E "test -f .*/include/${DIRNAME}/.*\.h(pp)?" conda/recipes/lib${LIBNAME}/meta.yaml | sort` - HEADER_DIFF=`diff <(echo "$HEADERS") <(echo "$META_TESTS")` - LIB_RETVAL=$? - - if [ "$LIB_RETVAL" != "0" ]; then - echo -e ">>>> FAILED: lib${LIBNAME} has different headers in include/${DIRNAME}/ and conda/recipes/lib${LIBNAME}/meta.yaml. The diff is shown below:" - echo -e "$HEADER_DIFF" - RETVAL=1 - fi -done - -exit $RETVAL diff --git a/conda/recipes/libcudf/meta.yaml b/conda/recipes/libcudf/meta.yaml index c844131ad31..7cff3359c5a 100644 --- a/conda/recipes/libcudf/meta.yaml +++ b/conda/recipes/libcudf/meta.yaml @@ -107,252 +107,6 @@ outputs: - dlpack {{ dlpack_version }} - gtest {{ gtest_version }} - gmock {{ gtest_version }} - test: - commands: - - test -f $PREFIX/lib/libcudf.so - - test -f $PREFIX/lib/libcudftestutil.a - - test -f $PREFIX/lib/libcudf_identify_stream_usage_mode_cudf.so - - test -f $PREFIX/lib/libcudf_identify_stream_usage_mode_testing.so - - test -f $PREFIX/include/cudf/aggregation.hpp - - test -f $PREFIX/include/cudf/ast/detail/expression_parser.hpp - - test -f $PREFIX/include/cudf/ast/detail/expression_transformer.hpp - - test -f $PREFIX/include/cudf/ast/detail/operators.hpp - - test -f $PREFIX/include/cudf/ast/expressions.hpp - - test -f $PREFIX/include/cudf/binaryop.hpp - - test -f $PREFIX/include/cudf/column/column.hpp - - test -f $PREFIX/include/cudf/column/column_factories.hpp - - test -f $PREFIX/include/cudf/column/column_view.hpp - - test -f $PREFIX/include/cudf/concatenate.hpp - - test -f $PREFIX/include/cudf/contiguous_split.hpp - - test -f $PREFIX/include/cudf/copying.hpp - - test -f $PREFIX/include/cudf/datetime.hpp - - test -f $PREFIX/include/cudf/timezone.hpp - - test -f $PREFIX/include/cudf/detail/aggregation/aggregation.hpp - - test -f $PREFIX/include/cudf/detail/aggregation/result_cache.hpp - - test -f $PREFIX/include/cudf/detail/binaryop.hpp - - test -f $PREFIX/include/cudf/detail/calendrical_month_sequence.cuh - - test -f $PREFIX/include/cudf/detail/concatenate.hpp - - test -f $PREFIX/include/cudf/detail/concatenate_masks.hpp - - test -f $PREFIX/include/cudf/detail/contiguous_split.hpp - - test -f $PREFIX/include/cudf/detail/copy.hpp - - test -f $PREFIX/include/cudf/detail/datetime.hpp - - test -f $PREFIX/include/cudf/detail/fill.hpp - - test -f $PREFIX/include/cudf/detail/gather.hpp - - test -f $PREFIX/include/cudf/detail/groupby.hpp - - test -f $PREFIX/include/cudf/detail/groupby/group_replace_nulls.hpp - - test -f $PREFIX/include/cudf/detail/groupby/sort_helper.hpp - - test -f $PREFIX/include/cudf/detail/interop.hpp - - test -f $PREFIX/include/cudf/detail/is_element_valid.hpp - - test -f $PREFIX/include/cudf/detail/join.hpp - - test -f $PREFIX/include/cudf/detail/label_bins.hpp - - test -f $PREFIX/include/cudf/detail/null_mask.hpp - - test -f $PREFIX/include/cudf/detail/nvtx/nvtx3.hpp - - test -f $PREFIX/include/cudf/detail/nvtx/ranges.hpp - - test -f $PREFIX/include/cudf/detail/quantiles.hpp - - test -f $PREFIX/include/cudf/detail/repeat.hpp - - test -f $PREFIX/include/cudf/detail/replace.hpp - - test -f $PREFIX/include/cudf/detail/reshape.hpp - - test -f $PREFIX/include/cudf/detail/rolling.hpp - - test -f $PREFIX/include/cudf/detail/round.hpp - - test -f $PREFIX/include/cudf/detail/scan.hpp - - test -f $PREFIX/include/cudf/detail/scatter.hpp - - test -f $PREFIX/include/cudf/detail/search.hpp - - test -f $PREFIX/include/cudf/detail/sequence.hpp - - test -f $PREFIX/include/cudf/detail/sorting.hpp - - test -f $PREFIX/include/cudf/detail/stream_compaction.hpp - - test -f $PREFIX/include/cudf/detail/structs/utilities.hpp - - test -f $PREFIX/include/cudf/detail/tdigest/tdigest.hpp - - test -f $PREFIX/include/cudf/detail/timezone.cuh - - test -f $PREFIX/include/cudf/detail/timezone.hpp - - test -f $PREFIX/include/cudf/detail/transform.hpp - - test -f $PREFIX/include/cudf/detail/transpose.hpp - - test -f $PREFIX/include/cudf/detail/unary.hpp - - test -f $PREFIX/include/cudf/detail/utilities/alignment.hpp - - test -f $PREFIX/include/cudf/detail/utilities/default_stream.hpp - - test -f $PREFIX/include/cudf/detail/utilities/int_fastdiv.h - - test -f $PREFIX/include/cudf/detail/utilities/integer_utils.hpp - - test -f $PREFIX/include/cudf/detail/utilities/linked_column.hpp - - test -f $PREFIX/include/cudf/detail/utilities/logger.hpp - - test -f $PREFIX/include/cudf/detail/utilities/pinned_host_vector.hpp - - test -f $PREFIX/include/cudf/detail/utilities/stacktrace.hpp - - test -f $PREFIX/include/cudf/detail/utilities/vector_factories.hpp - - test -f $PREFIX/include/cudf/detail/utilities/visitor_overload.hpp - - test -f $PREFIX/include/cudf/dictionary/detail/concatenate.hpp - - test -f $PREFIX/include/cudf/dictionary/detail/encode.hpp - - test -f $PREFIX/include/cudf/dictionary/detail/merge.hpp - - test -f $PREFIX/include/cudf/dictionary/detail/replace.hpp - - test -f $PREFIX/include/cudf/dictionary/detail/search.hpp - - test -f $PREFIX/include/cudf/dictionary/detail/update_keys.hpp - - test -f $PREFIX/include/cudf/dictionary/dictionary_column_view.hpp - - test -f $PREFIX/include/cudf/dictionary/dictionary_factories.hpp - - test -f $PREFIX/include/cudf/dictionary/encode.hpp - - test -f $PREFIX/include/cudf/dictionary/search.hpp - - test -f $PREFIX/include/cudf/dictionary/update_keys.hpp - - test -f $PREFIX/include/cudf/filling.hpp - - test -f $PREFIX/include/cudf/fixed_point/fixed_point.hpp - - test -f $PREFIX/include/cudf/fixed_point/temporary.hpp - - test -f $PREFIX/include/cudf/groupby.hpp - - test -f $PREFIX/include/cudf/hashing.hpp - - test -f $PREFIX/include/cudf/hashing/detail/hashing.hpp - - test -f $PREFIX/include/cudf/interop.hpp - - test -f $PREFIX/include/cudf/io/arrow_io_source.hpp - - test -f $PREFIX/include/cudf/io/avro.hpp - - test -f $PREFIX/include/cudf/io/csv.hpp - - test -f $PREFIX/include/cudf/io/data_sink.hpp - - test -f $PREFIX/include/cudf/io/datasource.hpp - - test -f $PREFIX/include/cudf/io/detail/avro.hpp - - test -f $PREFIX/include/cudf/io/detail/csv.hpp - - test -f $PREFIX/include/cudf/io/detail/json.hpp - - test -f $PREFIX/include/cudf/io/detail/tokenize_json.hpp - - test -f $PREFIX/include/cudf/io/detail/orc.hpp - - test -f $PREFIX/include/cudf/io/detail/parquet.hpp - - test -f $PREFIX/include/cudf/io/detail/utils.hpp - - test -f $PREFIX/include/cudf/io/json.hpp - - test -f $PREFIX/include/cudf/io/orc.hpp - - test -f $PREFIX/include/cudf/io/orc_metadata.hpp - - test -f $PREFIX/include/cudf/io/orc_types.hpp - - test -f $PREFIX/include/cudf/io/parquet.hpp - - test -f $PREFIX/include/cudf/io/parquet_metadata.hpp - - test -f $PREFIX/include/cudf/io/text/byte_range_info.hpp - - test -f $PREFIX/include/cudf/io/text/data_chunk_source.hpp - - test -f $PREFIX/include/cudf/io/text/data_chunk_source_factories.hpp - - test -f $PREFIX/include/cudf/io/text/detail/bgzip_utils.hpp - - test -f $PREFIX/include/cudf/io/text/detail/multistate.hpp - - test -f $PREFIX/include/cudf/io/text/detail/tile_state.hpp - - test -f $PREFIX/include/cudf/io/text/detail/trie.hpp - - test -f $PREFIX/include/cudf/io/text/multibyte_split.hpp - - test -f $PREFIX/include/cudf/io/types.hpp - - test -f $PREFIX/include/cudf/join.hpp - - test -f $PREFIX/include/cudf/labeling/label_bins.hpp - - test -f $PREFIX/include/cudf/lists/combine.hpp - - test -f $PREFIX/include/cudf/lists/contains.hpp - - test -f $PREFIX/include/cudf/lists/count_elements.hpp - - test -f $PREFIX/include/cudf/lists/detail/combine.hpp - - test -f $PREFIX/include/cudf/lists/detail/concatenate.hpp - - test -f $PREFIX/include/cudf/lists/detail/contains.hpp - - test -f $PREFIX/include/cudf/lists/detail/copying.hpp - - test -f $PREFIX/include/cudf/lists/detail/dremel.hpp - - test -f $PREFIX/include/cudf/lists/detail/extract.hpp - - test -f $PREFIX/include/cudf/lists/detail/interleave_columns.hpp - - test -f $PREFIX/include/cudf/lists/detail/lists_column_factories.hpp - - test -f $PREFIX/include/cudf/lists/detail/reverse.hpp - - test -f $PREFIX/include/cudf/lists/detail/scatter_helper.cuh - - test -f $PREFIX/include/cudf/lists/detail/set_operations.hpp - - test -f $PREFIX/include/cudf/lists/detail/sorting.hpp - - test -f $PREFIX/include/cudf/lists/detail/stream_compaction.hpp - - test -f $PREFIX/include/cudf/lists/explode.hpp - - test -f $PREFIX/include/cudf/lists/extract.hpp - - test -f $PREFIX/include/cudf/lists/filling.hpp - - test -f $PREFIX/include/cudf/lists/gather.hpp - - test -f $PREFIX/include/cudf/lists/list_view.hpp - - test -f $PREFIX/include/cudf/lists/lists_column_view.hpp - - test -f $PREFIX/include/cudf/lists/reverse.hpp - - test -f $PREFIX/include/cudf/lists/set_operations.hpp - - test -f $PREFIX/include/cudf/lists/sorting.hpp - - test -f $PREFIX/include/cudf/lists/stream_compaction.hpp - - test -f $PREFIX/include/cudf/merge.hpp - - test -f $PREFIX/include/cudf/null_mask.hpp - - test -f $PREFIX/include/cudf/partitioning.hpp - - test -f $PREFIX/include/cudf/quantiles.hpp - - test -f $PREFIX/include/cudf/reduction.hpp - - test -f $PREFIX/include/cudf/reduction/detail/reduction.hpp - - test -f $PREFIX/include/cudf/reduction/detail/reduction_functions.hpp - - test -f $PREFIX/include/cudf/reduction/detail/segmented_reduction_functions.hpp - - test -f $PREFIX/include/cudf/replace.hpp - - test -f $PREFIX/include/cudf/reshape.hpp - - test -f $PREFIX/include/cudf/rolling.hpp - - test -f $PREFIX/include/cudf/rolling/range_window_bounds.hpp - - test -f $PREFIX/include/cudf/round.hpp - - test -f $PREFIX/include/cudf/scalar/scalar.hpp - - test -f $PREFIX/include/cudf/scalar/scalar_factories.hpp - - test -f $PREFIX/include/cudf/search.hpp - - test -f $PREFIX/include/cudf/sorting.hpp - - test -f $PREFIX/include/cudf/stream_compaction.hpp - - test -f $PREFIX/include/cudf/strings/attributes.hpp - - test -f $PREFIX/include/cudf/strings/capitalize.hpp - - test -f $PREFIX/include/cudf/strings/case.hpp - - test -f $PREFIX/include/cudf/strings/char_types/char_cases.hpp - - test -f $PREFIX/include/cudf/strings/char_types/char_types.hpp - - test -f $PREFIX/include/cudf/strings/char_types/char_types_enum.hpp - - test -f $PREFIX/include/cudf/strings/combine.hpp - - test -f $PREFIX/include/cudf/strings/contains.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_booleans.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_datetime.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_durations.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_fixed_point.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_floats.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_integers.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_ipv4.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_lists.hpp - - test -f $PREFIX/include/cudf/strings/convert/convert_urls.hpp - - test -f $PREFIX/include/cudf/strings/detail/char_tables.hpp - - test -f $PREFIX/include/cudf/strings/detail/combine.hpp - - test -f $PREFIX/include/cudf/strings/detail/concatenate.hpp - - test -f $PREFIX/include/cudf/strings/detail/converters.hpp - - test -f $PREFIX/include/cudf/strings/detail/copying.hpp - - test -f $PREFIX/include/cudf/strings/detail/fill.hpp - - test -f $PREFIX/include/cudf/strings/detail/json.hpp - - test -f $PREFIX/include/cudf/strings/detail/replace.hpp - - test -f $PREFIX/include/cudf/strings/detail/utf8.hpp - - test -f $PREFIX/include/cudf/strings/detail/utilities.hpp - - test -f $PREFIX/include/cudf/strings/extract.hpp - - test -f $PREFIX/include/cudf/strings/find.hpp - - test -f $PREFIX/include/cudf/strings/find_multiple.hpp - - test -f $PREFIX/include/cudf/strings/findall.hpp - - test -f $PREFIX/include/cudf/strings/json.hpp - - test -f $PREFIX/include/cudf/strings/padding.hpp - - test -f $PREFIX/include/cudf/strings/regex/flags.hpp - - test -f $PREFIX/include/cudf/strings/regex/regex_program.hpp - - test -f $PREFIX/include/cudf/strings/repeat_strings.hpp - - test -f $PREFIX/include/cudf/strings/replace.hpp - - test -f $PREFIX/include/cudf/strings/replace_re.hpp - - test -f $PREFIX/include/cudf/strings/reverse.hpp - - test -f $PREFIX/include/cudf/strings/side_type.hpp - - test -f $PREFIX/include/cudf/strings/slice.hpp - - test -f $PREFIX/include/cudf/strings/split/partition.hpp - - test -f $PREFIX/include/cudf/strings/split/split.hpp - - test -f $PREFIX/include/cudf/strings/split/split_re.hpp - - test -f $PREFIX/include/cudf/strings/string_view.hpp - - test -f $PREFIX/include/cudf/strings/strings_column_view.hpp - - test -f $PREFIX/include/cudf/strings/strip.hpp - - test -f $PREFIX/include/cudf/strings/translate.hpp - - test -f $PREFIX/include/cudf/strings/wrap.hpp - - test -f $PREFIX/include/cudf/structs/detail/concatenate.hpp - - test -f $PREFIX/include/cudf/structs/struct_view.hpp - - test -f $PREFIX/include/cudf/structs/structs_column_view.hpp - - test -f $PREFIX/include/cudf/table/table.hpp - - test -f $PREFIX/include/cudf/table/table_view.hpp - - test -f $PREFIX/include/cudf/tdigest/tdigest_column_view.hpp - - test -f $PREFIX/include/cudf/transform.hpp - - test -f $PREFIX/include/cudf/transpose.hpp - - test -f $PREFIX/include/cudf/types.hpp - - test -f $PREFIX/include/cudf/unary.hpp - - test -f $PREFIX/include/cudf/utilities/bit.hpp - - test -f $PREFIX/include/cudf/utilities/default_stream.hpp - - test -f $PREFIX/include/cudf/utilities/error.hpp - - test -f $PREFIX/include/cudf/utilities/logger.hpp - - test -f $PREFIX/include/cudf/utilities/span.hpp - - test -f $PREFIX/include/cudf/utilities/traits.hpp - - test -f $PREFIX/include/cudf/utilities/type_checks.hpp - - test -f $PREFIX/include/cudf/utilities/type_dispatcher.hpp - - test -f $PREFIX/include/cudf/wrappers/dictionary.hpp - - test -f $PREFIX/include/cudf/wrappers/durations.hpp - - test -f $PREFIX/include/cudf/wrappers/timestamps.hpp - - test -f $PREFIX/include/cudf_test/base_fixture.hpp - - test -f $PREFIX/include/cudf_test/column_utilities.hpp - - test -f $PREFIX/include/cudf_test/column_wrapper.hpp - - test -f $PREFIX/include/cudf_test/cudf_gtest.hpp - - test -f $PREFIX/include/cudf_test/cxxopts.hpp - - test -f $PREFIX/include/cudf_test/default_stream.hpp - - test -f $PREFIX/include/cudf_test/detail/column_utilities.hpp - - test -f $PREFIX/include/cudf_test/file_utilities.hpp - - test -f $PREFIX/include/cudf_test/io_metadata_utilities.hpp - - test -f $PREFIX/include/cudf_test/iterator_utilities.hpp - - test -f $PREFIX/include/cudf_test/stream_checking_resource_adaptor.hpp - - test -f $PREFIX/include/cudf_test/table_utilities.hpp - - test -f $PREFIX/include/cudf_test/timestamp_utilities.cuh - - test -f $PREFIX/include/cudf_test/type_list_utilities.hpp - - test -f $PREFIX/include/cudf_test/type_lists.hpp about: home: https://rapids.ai/ license: Apache-2.0 @@ -378,9 +132,6 @@ outputs: run: - librdkafka {{ librdkafka_version }} - {{ pin_subpackage('libcudf', exact=True) }} - test: - commands: - - test -f $PREFIX/lib/libcudf_kafka.so about: home: https://rapids.ai/ license: Apache-2.0