[FEA] Remove inconsistencies in cython wrappers when handling order/null-precedence #14492
Labels
feature request
New feature or request
good first issue
Good for newcomers
Python
Affects Python cuDF API.
Where libcudf search/sort functions accept a
table_view
as input, one must specify the order (ascending or descending) and null precedence (beginning or end) as astd::vector
of length equal to the number of columns in thetable_view
(or else an empty such vector to used libcudf's defaults).In the cudf cython wrapping of these functions we are, in contrast, inconsistent in the way we handle these arguments. Some functions accept a list for both order and null precedence (e.g.
libcudf.sort.sort
); some accept a list for order but only a single value for null precedence (e.g.libcudf.sort.order_by
); some accept a list for neither order nor null precedence (e.g.libcudf.search.search_sorted
).This should be cleaned up and all such functions should uniformly accept a list for both order and null precedence. Higher-level python functions that operate on single columns and call the table interfaces should be responsible for any argument munging.
The text was updated successfully, but these errors were encountered: