Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose stream parameter in public strings find APIs #14060

Merged
merged 13 commits into from
Sep 21, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Sep 7, 2023

Description

Add stream parameter to public APIs:

  • cudf::strings::find()
  • cudf::strings::rfind()
  • cudf::strings::contains()
  • cudf::strings::starts_with()
  • cudf::strings::ends_with()
  • cudf::strings::findall()
  • cudf::strings::find_multiple()

Also cleaned up some of the doxygen comments.

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 7, 2023
@davidwendt davidwendt requested a review from a team as a code owner September 7, 2023 20:36
@davidwendt davidwendt self-assigned this Sep 7, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add tests for the new stream-based APIs (see any of my recent PRs for what those should look like)? They're mostly just to be safe, but on occasion they have revealed places where we're internally not forwarding input streams along and are just passing cudf::get_default_stream() instead.

@github-actions github-actions bot added the CMake CMake build issue label Sep 12, 2023
@davidwendt davidwendt requested a review from vyasr September 13, 2023 13:46
cpp/include/cudf/strings/find.hpp Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fe99e4b into rapidsai:branch-23.10 Sep 21, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants