-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose stream parameter in public strings find APIs #14060
Expose stream parameter in public strings find APIs #14060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add tests for the new stream-based APIs (see any of my recent PRs for what those should look like)? They're mostly just to be safe, but on occasion they have revealed places where we're internally not forwarding input streams along and are just passing cudf::get_default_stream()
instead.
/merge |
Description
Add stream parameter to public APIs:
cudf::strings::find()
cudf::strings::rfind()
cudf::strings::contains()
cudf::strings::starts_with()
cudf::strings::ends_with()
cudf::strings::findall()
cudf::strings::find_multiple()
Also cleaned up some of the doxygen comments.
Reference #13744
Checklist