Remove debug print in a Parquet test #14063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
tests
karthikeyann
approved these changes
Sep 8, 2023
ttnghia
reviewed
Sep 9, 2023
cpp/tests/io/parquet_test.cpp
Outdated
| @@ -52,6 +52,9 @@ | |||
| #include <random> | |||
| #include <type_traits> | |||
|
|
|||
| // Set this to true to enable printing, for debugging. | |||
| auto constexpr print_enabled = false; | |||
There was a problem hiding this comment.
Should this be read from env variable?
There was a problem hiding this comment.
I copied the mechanism from structs_tests. Either way, this is removed now :)
davidwendt
reviewed
Sep 11, 2023
…disable-test-print
…to disable-test-print
davidwendt
approved these changes
Sep 11, 2023
ttnghia
approved these changes
Sep 11, 2023
vuule
changed the title
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed a debug print. That's it.
Checklist