Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calls to copy_bitmask to pass stream parameter #14158

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Fix calls to copy_bitmask to pass stream parameter #14158

merged 4 commits into from
Sep 22, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Fixes a couple places where cudf::copy_bitmask was called instead of cudf::detail::copy_bitmask to pass the available stream (and mr) parameters.

Found while reviewing #14121
Reference: #14121 (comment)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Sep 21, 2023
@davidwendt davidwendt requested a review from a team as a code owner September 21, 2023 17:57
@davidwendt davidwendt self-assigned this Sep 21, 2023
@davidwendt davidwendt requested a review from bdice September 22, 2023 01:11
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 98b1bc6 into rapidsai:branch-23.10 Sep 22, 2023
54 checks passed
@davidwendt davidwendt deleted the copy-bitmask-stream branch September 22, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @mythrocks