Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining datetime APIs to pylibcudf #17143

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Add remaining datetime APIs to pylibcudf #17143

merged 8 commits into from
Oct 31, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 22, 2024 •
edited
Loading

Description

Apart of #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Oct 22, 2024
@Matt711 Matt711 self-assigned this Oct 22, 2024
@Matt711 Matt711 changed the title [WIP] Add remaining datetime APPIs to pylibcudf [WIP] Add remaining datetime APIs to pylibcudf Oct 22, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Oct 22, 2024
@Matt711 Matt711 marked this pull request as ready for review October 23, 2024 23:16
@Matt711 Matt711 requested a review from a team as a code owner October 23, 2024 23:16
@Matt711 Matt711 requested review from vyasr and mroeschke October 23, 2024 23:16
@Matt711 Matt711 changed the title [WIP] Add remaining datetime APIs to pylibcudf Add remaining datetime APIs to pylibcudf Oct 23, 2024
brandon-b-miller
brandon-b-miller approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise lgtm

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 31, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3cf186c into rapidsai:branch-24.12 Oct 31, 2024
102 checks passed
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 31, 2024

To keep forward momentum, I'll add these pylibcudf functions to cudf in a follow up. I'll also deprecate the single component datetime extraction methods in a follow-up.

This was referenced Oct 31, 2024
Open
Merged
rapids-bot bot pushed a commit that referenced this pull request Nov 5, 2024
@Matt711
Deprecate single component extraction methods in libcudf (#17221)
ac5b3ed 
This PR deprecates the single component extraction methods (eg. `cudf::datetime::extract_year`) that are already covered by `cudf::datetime::extract_datetime_component`.
xref #17143

Authors:
  - Matthew Murray (https://github.com/Matt711)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Karthikeyan (https://github.com/karthikeyann)

URL: #17221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @brandon-b-miller