Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GNN Packages #4765

Merged
merged 12 commits into from
Nov 22, 2024
Merged

Conversation

alexbarghi-nv
Copy link
Member

Removes the GNN packages, which are now part of cugraph-gnn.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this branch and searched like this:

git grep -E -i 'dgl|pyg'

Found some more things that I think should be deleted.

test files:

test code:

cugraph/ci/test.sh

Lines 102 to 107 in c712a98

echo "Python pytest for cugraph_pyg (single-GPU only)..."
conda list
cd ${CUGRAPH_ROOT}/python/cugraph-pyg/cugraph_pyg
# rmat is not tested because of MG testing
pytest -sv -m sg --cache-clear --junitxml=${CUGRAPH_ROOT}/junit-cugraph-pytests.xml -v --cov-config=.coveragerc --cov=cugraph_pyg --cov-report=xml:${WORKSPACE}/python/cugraph_pyg/cugraph-coverage.xml --cov-report term --ignore=raft --benchmark-disable
echo "Ran Python pytest for cugraph_pyg : return code was: $?, test script exit code is now: $EXITCODE"

the conda recipes:

Test coverage config:

cugraph-pyg/cugraph_pyg/*

cugraph-pyg/cugraph_pyg/tests/*

@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner November 15, 2024 00:01
@github-actions github-actions bot added the ci label Nov 15, 2024
@alexbarghi-nv
Copy link
Member Author

I pulled this branch and searched like this:

git grep -E -i 'dgl|pyg'

Found some more things that I think should be deleted.

test files:

test code:

cugraph/ci/test.sh

Lines 102 to 107 in c712a98

echo "Python pytest for cugraph_pyg (single-GPU only)..."
conda list
cd ${CUGRAPH_ROOT}/python/cugraph-pyg/cugraph_pyg
# rmat is not tested because of MG testing
pytest -sv -m sg --cache-clear --junitxml=${CUGRAPH_ROOT}/junit-cugraph-pytests.xml -v --cov-config=.coveragerc --cov=cugraph_pyg --cov-report=xml:${WORKSPACE}/python/cugraph_pyg/cugraph-coverage.xml --cov-report term --ignore=raft --benchmark-disable
echo "Ran Python pytest for cugraph_pyg : return code was: $?, test script exit code is now: $EXITCODE"

the conda recipes:

Test coverage config:

cugraph-pyg/cugraph_pyg/*

cugraph-pyg/cugraph_pyg/tests/*

These should be taken care of now.

@alexbarghi-nv
Copy link
Member Author

The benchmarks are going to stay for now; those will go away in 25.02.

@alexbarghi-nv alexbarghi-nv self-assigned this Nov 15, 2024
@alexbarghi-nv alexbarghi-nv added improvement Improvement / enhancement to an existing function breaking Breaking change labels Nov 15, 2024
@jameslamb
Copy link
Member

CI here is going to fail until some other things are resolved.

@bdice
Copy link
Contributor

bdice commented Nov 22, 2024

I merged in the upstream and resolved conflicts with #4762. Based on the mostly-complete CI run from 0694814, I think we might be close to having passing CI now that RAFT kernel symbol failures are resolved. We will know in the morning. 👍

@bdice
Copy link
Contributor

bdice commented Nov 22, 2024

/merge

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks right but I admit I'm relying more on the passing CI status and working nightly packages to say for sure.

@rapids-bot rapids-bot bot merged commit 5e19f4a into rapidsai:branch-24.12 Nov 22, 2024
71 checks passed
@alexbarghi-nv alexbarghi-nv deleted the remove-gnn-packages branch November 22, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change ci conda improvement Improvement / enhancement to an existing function python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants