-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GNN Packages #4765
Remove GNN Packages #4765
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled this branch and searched like this:
git grep -E -i 'dgl|pyg'
Found some more things that I think should be deleted.
test files:
- https://github.com/rapidsai/cugraph/blob/branch-24.12/ci/run_cugraph_pyg_pytests.sh
- https://github.com/rapidsai/cugraph/blob/branch-24.12/ci/run_cugraph_dgl_pytests.sh
test code:
Lines 102 to 107 in c712a98
echo "Python pytest for cugraph_pyg (single-GPU only)..." | |
conda list | |
cd ${CUGRAPH_ROOT}/python/cugraph-pyg/cugraph_pyg | |
# rmat is not tested because of MG testing | |
pytest -sv -m sg --cache-clear --junitxml=${CUGRAPH_ROOT}/junit-cugraph-pytests.xml -v --cov-config=.coveragerc --cov=cugraph_pyg --cov-report=xml:${WORKSPACE}/python/cugraph_pyg/cugraph-coverage.xml --cov-report term --ignore=raft --benchmark-disable | |
echo "Ran Python pytest for cugraph_pyg : return code was: $?, test script exit code is now: $EXITCODE" |
the conda recipes:
- https://github.com/rapidsai/cugraph/tree/branch-24.12/conda/recipes/cugraph-dgl
- https://github.com/rapidsai/cugraph/tree/branch-24.12/conda/recipes/cugraph-pyg
Test coverage config:
Line 4 in c712a98
cugraph-pyg/cugraph_pyg/* |
Line 8 in c712a98
cugraph-pyg/cugraph_pyg/tests/* |
These should be taken care of now. |
The benchmarks are going to stay for now; those will go away in 25.02. |
CI here is going to fail until some other things are resolved.
|
…v/cugraph into remove-gnn-packages
/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks right but I admit I'm relying more on the passing CI status and working nightly packages to say for sure.
Removes the GNN packages, which are now part of cugraph-gnn.