Modify cuvs-bench to be able to generate ground truth in CPU systems #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this. I think it looks good. Should we also add the cuvs and cupy dependencies to the gpu cuvs-bench python package? Right now users get a module not found error because those aren't installed w/ the gpu-enabled package. |
cjnolet
added
improvement
divyegala
reviewed
Nov 19, 2024
Comment on lines
+132
to
+152
| if metric == "squeclidean": | ||
| diff = queries[:, xp.newaxis, :] - dataset[xp.newaxis, :, :] | ||
| dist_sq = xp.sum(diff**2, axis=2) # Shape: (n_queries, n_samples) | ||
|
|
||
| indices = xp.argpartition(dist_sq, kth=k - 1, axis=1)[:, :k] | ||
| distances = xp.take_along_axis(dist_sq, indices, axis=1) | ||
|
|
||
| sorted_idx = xp.argsort(distances, axis=1) | ||
| distances = xp.take_along_axis(distances, sorted_idx, axis=1) | ||
| indices = xp.take_along_axis(indices, sorted_idx, axis=1) | ||
|
|
||
| elif metric == "inner_product": | ||
| similarities = xp.dot( | ||
| queries, dataset.T | ||
| ) # Shape: (n_queries, n_samples) | ||
|
|
||
| neg_similarities = -similarities | ||
| indices = xp.argpartition(neg_similarities, kth=k - 1, axis=1)[:, :k] | ||
| distances = xp.take_along_axis(similarities, indices, axis=1) | ||
|
|
||
| sorted_idx = xp.argsort(-distances, axis=1) |
There was a problem hiding this comment.
Have you been able to verify that this works as expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR allows calculating ground truth for cuvs-bench on CPU systems. Current version uses a simple NumPy brute force, perhaps we should consider using faiss? cc @cjnolet @divyegala