Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C++ and Python mock tests for compatibility mode-dependent code paths #556

Open
kingcrimsontianyu opened this issue Nov 15, 2024 · 0 comments
Open

Add C++ and Python mock tests for compatibility mode-dependent code paths #556

kingcrimsontianyu opened this issue Nov 15, 2024 · 0 comments
Assignees
@kingcrimsontianyu
Labels
c++ Affects the C++ API of KvikIO non-breaking Introduces a non-breaking change python Affects the Python API of KvikIO

Comments

@kingcrimsontianyu
Copy link
Contributor

Some key components in KvikIO such as the methods of FileHandle or BatchHandle branch on different compatibility modes (ON, OFF, AUTO). Commonly, the CI and local environment do not satisfy the system requirement for GDS I/O, leaving the code on the OFF path (or AUTO but inferred at runtime to be OFF) untested.

We may improve our testing methodology (and code coverage) by introducing mock tests for the C++ and Python code.
@kingcrimsontianyu kingcrimsontianyu added c++ Affects the C++ API of KvikIO non-breaking Introduces a non-breaking change python Affects the Python API of KvikIO labels Nov 15, 2024
@kingcrimsontianyu kingcrimsontianyu self-assigned this Nov 15, 2024
@kingcrimsontianyu kingcrimsontianyu mentioned this issue Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingcrimsontianyu kingcrimsontianyu

Labels
c++ Affects the C++ API of KvikIO non-breaking Introduces a non-breaking change python Affects the Python API of KvikIO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kingcrimsontianyu