-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify-pyproject-license hook #30
Add verify-pyproject-license hook #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
I'm fine merging this with only pyproject license support since that is the more immediate need (where we get bit by wheeltamer), but we probably want to 1) add tooling to also validate our conda meta.yaml files, and 2) add logic for validating other fields. For 2, other fields we should standardize:
- Author name (NVIDIA Corporation)
- Classifiers: some packages will want more classifiers than others, but there are some base ones that we ought to be able to standardize. For instance, making sure the Python versions are consistent.
Just as a survey of various Python build tools:
I don't know what our constraints are with respect to the internal wheel validation process, but using SPDX and a classifier would seem to be the optimal solution imo. |
It looks like all review requests were resolved. Requesting a new round of reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some clean up and deduplicating, otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments - please resolve them as you see fit. You can merge without waiting for more review from me if you wish.
Contributes to #29.