Add verify-pyproject-license hook

.pre-commit-hooks.yaml

@@ -32,3 +32,12 @@
         pyproject[.]toml$|
         setup[.]cfg$
   args: [--fix]
+- id: verify-pyproject-license
+  name: verify-pyproject-license
+  description: make sure pyproject.toml license is correct
+  entry: verify-pyproject-license
+  language: python
+  files: |
+    (?x)
+        pyproject[.]toml$
+  args: [--fix]

pyproject.toml

@@ -35,6 +35,7 @@ dependencies = [
     "bashlex",
     "gitpython",
     "rich",
+    "tomlkit",
 ]
 
 [project.optional-dependencies]
@@ -46,6 +47,7 @@ test = [
 [project.scripts]
 verify-conda-yes = "rapids_pre_commit_hooks.shell.verify_conda_yes:main"
 verify-copyright = "rapids_pre_commit_hooks.copyright:main"
+verify-pyproject-license = "rapids_pre_commit_hooks.pyproject_license:main"
 
 [tool.setuptools]
 packages = { "find" = { where = ["src"] } }

src/rapids_pre_commit_hooks/pyproject_license.py

@@ -0,0 +1,100 @@
+# Copyright (c) 2024, NVIDIA CORPORATION.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import copy
+import uuid
+
+import tomlkit
+import tomlkit.exceptions
+
+from .lint import LintMain
+
+RAPIDS_LICENSE = "Apache 2.0"
+ACCEPTABLE_LICENSES = {
+    RAPIDS_LICENSE,
+    "BSD-3-Clause",
+}
+
+
+def find_value_location(document, key, append):
+    copied_document = copy.deepcopy(document)
+    placeholder = uuid.uuid4()
+    placeholder_toml = tomlkit.string(str(placeholder))
+    placeholder_repr = placeholder_toml.as_string()
+
+    # tomlkit does not provide "mark" information to determine where exactly in the
+    # document a value is located, so instead we replace it with a placeholder and
+    # look for that in the new document.
+    node = copied_document
+    while len(key) > (0 if append else 1):
+        node = node[key[0]]
+        key = key[1:]
+    if append:
+        node.add(str(placeholder), placeholder_toml)
+    else:
+        old_value = node[key[0]]
+        node[key[0]] = str(placeholder)
+
+    value_to_find = (
+        f"{placeholder} = {placeholder_repr}" if append else placeholder_repr
+    )
+    begin_loc = copied_document.as_string().find(value_to_find)
+    end_loc = begin_loc + (0 if append else len(old_value.as_string()))
+    return begin_loc, end_loc
+
+
+def check_pyproject_license(linter, args):
+    document = tomlkit.loads(linter.content)
+    try:
+        add_project_table = True
+        project_table = document["project"]
+        add_project_table = project_table.is_super_table()
+        license_value = project_table["license"]["text"]
+    except tomlkit.exceptions.NonExistentKey:
+        if add_project_table:
+            loc = (len(linter.content), len(linter.content))
+            linter.add_warning(
+                loc, f'add project.license with value {{ text = "{RAPIDS_LICENSE}" }}'
+            ).add_replacement(
+                loc,
+                "[project]\nlicense = "
+                f"{{ text = {tomlkit.string(RAPIDS_LICENSE).as_string()} }}\n",
+            )
+        else:
+            loc = find_value_location(document, ("project",), True)
+            linter.add_warning(
+                loc, f'add project.license with value {{ text = "{RAPIDS_LICENSE}" }}'
+            ).add_replacement(
+                loc,
+                "license = "
+                f"{{ text = {tomlkit.string(RAPIDS_LICENSE).as_string()} }}\n",
+            )
+        return
+
+    if license_value not in ACCEPTABLE_LICENSES:
+        loc = find_value_location(document, ("project", "license", "text"), False)
+        linter.add_warning(loc, f'license should be "{RAPIDS_LICENSE}"')
+
+
+def main():
+    m = LintMain()
+    m.argparser.description = (
+        f'Verify that pyproject.toml has the correct license ("{RAPIDS_LICENSE}").'
+    )
+    with m.execute() as ctx:
+        ctx.add_check(check_pyproject_license)
+
+
+if __name__ == "__main__":
+    main()

test/rapids_pre_commit_hooks/test_pyproject_license.py

@@ -0,0 +1,192 @@
+# Copyright (c) 2024, NVIDIA CORPORATION.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from textwrap import dedent
+
+import pytest
+import tomlkit
+
+from rapids_pre_commit_hooks import pyproject_license
+from rapids_pre_commit_hooks.lint import Linter
+
+
+@pytest.mark.parametrize(
+    ["key", "append", "loc"],
+    [
+        (
+            ("table", "key1"),
+            False,
+            (15, 22),
+        ),
+        (
+            ("table", "key2"),
+            False,
+            (30, 32),
+        ),
+        (
+            ("table", "key3"),
+            False,
+            (40, 60),
+        ),
+        (
+            ("table", "key3", "nested"),
+            False,
+            (51, 58),
+        ),
+        (
+            ("table",),
+            True,
+            (61, 61),
+        ),
+    ],
+)
+def test_find_value_location(key, append, loc):
+    CONTENT = dedent(
+        """\
+        [table]
+        key1 = "value"
+        key2 = 42
+        key3 = { nested = "value" }
+
+        [table2]
+        key = "value"
+        """
+    )
+    parsed_doc = tomlkit.loads(CONTENT)
+    assert pyproject_license.find_value_location(parsed_doc, key, append) == loc
+    assert parsed_doc.as_string() == CONTENT
+
+
+@pytest.mark.parametrize(
+    ["document", "loc", "message", "replacement_loc", "replacement_text"],
+    [
+        (
+            dedent(
+                """\
+                [project]
+                license = { text = "Apache-2.0" }
+                """
+            ),
+            (29, 41),
+            'license should be "Apache 2.0"',
+            None,
+            None,
+        ),
+        (
+            dedent(
+                """\
+                [project]
+                license = { text = "BSD" }
+                """
+            ),
+            (29, 34),
+            'license should be "Apache 2.0"',
+            None,
+            None,
+        ),
+        *(
+            (
+                dedent(
+                    f"""\
+                    [project]
+                    license = {{ text = {tomlkit.string(license).as_string()} }}
+                    """
+                ),
+                None,
+                None,
+                None,
+                None,
+            )
+            for license in pyproject_license.ACCEPTABLE_LICENSES
+        ),
+        (
+            dedent(
+                """\
+                [project]
+                license = { text = 'Apache 2.0' }  # Single quotes are fine
+                """
+            ),
+            None,
+            None,
+            None,
+            None,
+        ),
+        (
+            dedent(
+                """\
+                [build-system]
+                requires = ["scikit-build-core"]
+                """
+            ),
+            (48, 48),
+            'add project.license with value { text = "Apache 2.0" }',
+            (48, 48),
+            '[project]\nlicense = { text = "Apache 2.0" }\n',
+        ),
+        (
+            dedent(
+                """\
+                [project]
+                name = "test-project"
+
+                [build-system]
+                requires = ["scikit-build-core"]
+                """
+            ),
+            (32, 32),
+            'add project.license with value { text = "Apache 2.0" }',
+            (32, 32),
+            'license = { text = "Apache 2.0" }\n',
+        ),
+        (
+            dedent(
+                """\
+                [project]
+                name = "test-project"
+
+                [project.optional-dependencies]
+                test = ["pytest"]
+                """
+            ),
+            (32, 32),
+            'add project.license with value { text = "Apache 2.0" }',
+            (32, 32),
+            'license = { text = "Apache 2.0" }\n',
+        ),
+        (
+            dedent(
+                """\
+                [project.optional-dependencies]
+                test = ["pytest"]
+                """
+            ),
+            (50, 50),
+            'add project.license with value { text = "Apache 2.0" }',
+            (50, 50),
+            '[project]\nlicense = { text = "Apache 2.0" }\n',
+        ),
+    ],
+)
+def test_check_pyproject_license(
+    document, loc, message, replacement_loc, replacement_text
+):
+    linter = Linter("pyproject.toml", document)
+    pyproject_license.check_pyproject_license(linter, None)
+
+    expected_linter = Linter("pyproject.toml", document)
+    if loc and message:
+        w = expected_linter.add_warning(loc, message)
+        if replacement_loc and replacement_text:
+            w.add_replacement(replacement_loc, replacement_text)
+    assert linter.warnings == expected_linter.warnings