Expand interface to support trace links #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dale-Koenig
commented
Mar 4, 2024
Dale-Koenig
commented
Mar 4, 2024
Dale-Koenig
commented
Mar 5, 2024
| virtual std::unique_ptr<IAlicaTrace> create(const std::string& opName, std::optional<const std::string> parent = std::nullopt) const = 0; | ||
| // Two argument version of create. Deprecated. | ||
| virtual std::unique_ptr<IAlicaTrace> create(const std::string& opName, std::optional<const std::string> parent = std::nullopt) const { return nullptr; } | ||
| virtual std::unique_ptr<IAlicaTrace> create(const std::string& opName, std::optional<const std::string> parent_context, const std::vector<SpanLink>&) const |
There was a problem hiding this comment.
My idea is that if we make a breaking changes release, we can remove the two arg version and add default args to the three arg version.
veerajsk
approved these changes
Mar 5, 2024
bjoernschroeder
approved these changes
Mar 6, 2024
|
I realized this doesn't really work. Since alica generates the traces for you, and the only interaction the user has is to create the context, to support links we must also support returning context with links included |
Dale-Koenig
force-pushed
the
dk/trace_links
branch
from
d4f749f to
f11f5a2
Compare
Dale-Koenig
force-pushed
the
dk/trace_links
branch
from
f11f5a2 to
21295fa
Compare
veerajsk
reviewed
Mar 7, 2024
bjoernschroeder
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opentelemetry supports indirect links to other spans. Expand the interface to support this, with backwards compatibility.