Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom board files #119

Open
shalxmva opened this issue Nov 10, 2024 · 4 comments
Open

Support for custom board files #119

shalxmva opened this issue Nov 10, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@shalxmva
Copy link

shalxmva commented Nov 10, 2024

I have a custom board files on a special folder on my project, and added that folder to PICO_BOARD_HEADER_DIRS variable.

I looked into the switchBoard.mts file and in askBoard function, only the sdk board folder is used to look for board files.

Is there any possibility to look into the folders added to that variable, so custom board files could be used without copying them to the sdk's board folder?

@shalxmva
Copy link
Author

I created a change, so maybe this will help:

 https://github.com/shalxmva/pico-vscode/tree/develop

Also this change gets the current project_name from CMakeCache.txt file ( my project sets the project name using ${PICO_BOARD} variable )

The project i am working on is
https://github.com/Team-Resurgent/Modxo/tree/sdk2_board_files

@will-v-pi
Copy link
Collaborator

I don't think your fix will work when PICO_BOARD_HEADER_DIRS is set to a list, or when it includes relative paths - feel free to raise a PR (you closed #120?) if you want to discuss fixes

Also this change gets the current project_name from CMakeCache.txt file ( my project sets the project name using ${PICO_BOARD} variable )

I don't think we want to add this, as once you're using CMake variables for the project name you should probably be using the CMake Tools integration as well, which handles all that and more.

@will-v-pi will-v-pi added the enhancement New feature or request label Nov 12, 2024
@shalxmva
Copy link
Author

shalxmva commented Nov 12, 2024

PR was closed automatically,
i didnt see that i was pulling it to master, and i cant see a develop branch.

I can create the PR to make a discussion about this and i can contribute by doing this enhacement.

Do i make the PR to any particular branch on this repo?

@will-v-pi
Copy link
Collaborator

The main branch is fine for a PR - as this software is still under development we haven't created a separate develop branch yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants