Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to have a fixed width #15

Open
denkstream opened this issue Jul 10, 2022 · 3 comments
Open

Option to have a fixed width #15

denkstream opened this issue Jul 10, 2022 · 3 comments

Comments

@denkstream
Copy link

Is there a possibility to add an option to have fixed-width icons? Usualy its enough to have fa-fw added to class like <i class="fas fa-envelope-open-text fa-fw"></i>

@rasteiner
Copy link
Owner

What about just using

<i class="<?= $page->icon() ?> fa-fw"></i>

?

Or do you mean having an option in the plugin UI?

@denkstream
Copy link
Author

What about just using


<i class="<?= $page->icon() ?> fa-fw"></i>

?

Or do you mean having an option in the plugin UI?

Yupp - UI option would be excellent for the not so tech savvy users :-)

@rasteiner
Copy link
Owner

rasteiner commented Jul 14, 2022

I'm not sure I understand the use case.

<i class="<?= $page->icon() ?> fa-fw"></i>

is what you would write in the template, and it's up to you (the designer / developer) to choose whether an icon in a certain spot should be fixed width or height.
IMHO, the user in the panel shouldn't have a choice about how an icon is placed into the layout. I mean it probably depends on whether you want several icons to align vertically or horizontally, letting the user decide if an icon is fa-fw or not just adds an opportunity to let him choose the wrong one, or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants