Adding dry contact control #253
Conversation
|
@dkerr64 Thanks for the help with rebasing. As an update, the current version compiles and flashes properly and allows for switching to dry contact protocol via the settings page (using a value of 3). The next test I performed was to wire up an open/closed limit switch. I am using just one switch with 3 terminals (ground, NC, and NO) to act as both switches (hopefully this shouldn't affect things). When I 'close the door' (bring close limit switch closed, open limit switch open) for the first time, HomeKit and the logs show a proper update to closed. But after that opening or closing the switches does not result in any more updates. This probably has to do with the OneButton functions I implemented, so I'll take a look at those next. |
|
I haven’t reviewed the code yet, but just fyi - There needs to be logic to update HomeKit to opening and closing as well as open and closed. door opening and door closing is whenever both limit switches are open. To know which of the two you have to keep track of the last state of both switches. If open limit was closed and is now open, the door is closing, and vice versa. This will be impossible to mimic with an no/nc switch unless you can somehow hold the switch between states so that both no and nc are open. |
|
That's a good point. The logic should be there in the dryContactLoop function to capture the opening/closing states, but I should test it. I do have two limit switches, I was just planning to wire one for convenience in my actual garage setup. I will go ahead and connect both of them for testing to see if opening/closing are properly captured. @PaulWieland On a related note I did have a question for you. I took the dryContactLoop function from the mqtt code and it is currently basically unchanged in ratgdo.cpp here. I was confused about the logic where it is taking actions if the control protocol is not dry contact. Could you help me understand what is the purpose of those actions (print message, call open/close door function, set dryContactDoorOpen/Close to false)? It seems like I might be able to remove them here. |
|
The dry contact loop handles the inputs on the control board for dry contact control over the door opener. There are inputs that let you trigger the door to open or close, or toggle the light on/off. |
|
I guess to add further clarification… those inputs are re-purposed when you have a dry contact controlled door to read the limit switches. If you have a dry contact control door, you would never need dry contact controls. |
|
FYI that #254 wants to use dry contact support to control a gate rather than garage door... and requests that we have option to remove the light service from the accessory. |
No description provided.