Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move num_cpu note to resources page to avoid confusion #48871

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Superskyyy
Copy link
Contributor

@Superskyyy Superskyyy commented Nov 22, 2024

closes: #48867

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Superskyyy Superskyyy requested a review from a team as a code owner November 22, 2024 18:31
@Superskyyy Superskyyy marked this pull request as draft November 22, 2024 19:10
@can-anyscale
Copy link
Collaborator

@Superskyyy the following places in the doc refers to omp-num-thread-note which you deleted in your PR

[2024-11-22T18:47:06Z] /ray/doc/source/serve/resource-allocation.md:86: WARNING: 'myst' cross-reference target not found: 'omp-num-thread-note' [myst.xref_missing]
--
  | [2024-11-22T18:47:07Z] /ray/python/ray/train/tensorflow/tensorflow_trainer.py:docstring of ray.train.tensorflow.tensorflow_trainer.TensorflowTrainer:34: WARNING: undefined label: 'omp-num-thread-note'
  | [2024-11-22T18:47:07Z] /ray/doc/source/train/distributed-tensorflow-keras.rst:69: WARNING: undefined label: 'omp-num-thread-note'

@Superskyyy
Copy link
Contributor Author

@Superskyyy the following places in the doc refers to omp-num-thread-note which you deleted in your PR

[2024-11-22T18:47:06Z] /ray/doc/source/serve/resource-allocation.md:86: WARNING: 'myst' cross-reference target not found: 'omp-num-thread-note' [myst.xref_missing]
--
  | [2024-11-22T18:47:07Z] /ray/python/ray/train/tensorflow/tensorflow_trainer.py:docstring of ray.train.tensorflow.tensorflow_trainer.TensorflowTrainer:34: WARNING: undefined label: 'omp-num-thread-note'
  | [2024-11-22T18:47:07Z] /ray/doc/source/train/distributed-tensorflow-keras.rst:69: WARNING: undefined label: 'omp-num-thread-note'

I see, let me fix that up.

@Superskyyy Superskyyy marked this pull request as ready for review November 22, 2024 20:39
@Superskyyy
Copy link
Contributor Author

@can-anyscale Hi please review again. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Misleading documentation about num_cpus and physical resources
2 participants