Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Clarify schema validation error #48882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 22, 2024

Why are these changes needed?

ray.data.range(1).groupby("does_not_exist").count().materialize()

Before

ValueError: The column 'does_not_exist' does not exist in the schema 'Column  Type
------  ----
id      int64'.

After

ValueError: You specified the column 'does_not_exist', but there's no such column in the dataset. The dataset has columns: {'id'}

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani changed the title [Data] Improve schema validation [Data] Clarify schema validation error Nov 22, 2024
Comment on lines -84 to -85
"The column '{}' does not exist in the "
"schema '{}'.".format(column, schema)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to print full schema (though fixing the formatting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants