Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links to examples folder (also in lightgbm_ray) #233

Open
mirekphd opened this issue Sep 3, 2022 · 0 comments
Open

Broken links to examples folder (also in lightgbm_ray) #233

mirekphd opened this issue Sep 3, 2022 · 0 comments

Comments

@mirekphd
Copy link

mirekphd commented Sep 3, 2022

@krfricke I think merging this PR made example files much harder to find via the remote web interface i.e. on Github... isn't it because symlinks work only locally?

Resulting empty folders (due to failing symlinks):
https://github.com/ray-project/xgboost_ray/blob/master/examples
https://github.com/ray-project/lightgbm_ray/blob/master/examples
https://github.com/ray-project/lightgbm_ray/blob/main/examples

Resulting missing file (HTTP 404):
https://github.com/ray-project/xgboost_ray/blob/main/examples

... vs. correct (albeit redundantly nested) ones:
https://github.com/ray-project/lightgbm_ray/tree/main/lightgbm_ray/examples
https://github.com/ray-project/xgboost_ray/tree/master/xgboost_ray/examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant