Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding same person into group #5

Open
raydenlim opened this issue Nov 17, 2023 · 1 comment
Open

Adding same person into group #5

raydenlim opened this issue Nov 17, 2023 · 1 comment

Comments

@raydenlim
Copy link
Owner

raydenlim commented Nov 17, 2023

This issue is similar to issue 3 and issue 4

Hence, i'll just put the severity as low.

As mentioned in previous issues, the wrong person object referencing led to the group list not being updated properly.

Hence, the same person can be added repeatedly to the same group just by exploiting the edit function for the email field.

image.png

image.png

@nus-pe-script
Copy link

nus-pe-script commented Nov 20, 2023

Team's Response

We believe that this is a duplicate as once we fix issue #1406, this issue will be fixed too.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Identical Person in Group

image.png

From my understanding, you guys check index using email. However, I was still able to add the same email into a group:

image.png

You can try replicating this bug by:

  1. editing the original AlexYeoh's email to something else
  2. Create a new person with alexyeoh's old email
  3. Join said person to the same tut group.

[original: nus-cs2103-AY2324S1/pe-interim#1167] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is a functionality bug as this bug should not be allowed, but it worked in his/her case.
We labelled it a low severity as we believe that it is not common for users to do the action(what the tester tested) or change their email(we intended email changes in the case of typos, not for deliberate changes).

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue type

Team chose [type.FunctionalityBug]
Originally [type.FeatureFlaw]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants