Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 nationality only? #9

Open
raydenlim opened this issue Nov 17, 2023 · 1 comment
Open

2 nationality only? #9

raydenlim opened this issue Nov 17, 2023 · 1 comment

Comments

@raydenlim
Copy link
Owner

raydenlim commented Nov 17, 2023

image.png

The help/ claim is that the checker will check if members are from different nationalities.
However, there are only 2 nationalities listed/valid local and foreigner.

image.png

What if the group is made up of 5 foreigners of different nationality? or what about permanent residents.

In this case, your app may not be able to accommodate to the requirements of the module, as it discriminates against foreigners of different nationalities.

@soc-se-bot
Copy link

soc-se-bot commented Nov 20, 2023

Team's Response

We believe that it is not required to specify the nationality. In CS2101/CS2103T, it is stated that there must be at least one local and one foreigner. It is also quite confusing what is the bug in the documentation. The last line in the review also implies that it is not a documentation bug. We do not think we are discriminating anyone :)

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: I apologize for the confusing bug report:

In essence, you guys mentioned that teams comprising members entirely of a single nationality is NOT allowed.

Since there are only 2 types of nationalities, i.e local and foreigner. We cannot distinguish e.g Malaysian from Chinese or Korean etc. They will just be lumped into foreigner group.(more below)

"We believe that it is not required to specify the nationality."

Looking at your User Guide:

image.png

Looking at your Developer Guide:

image.png

It shows that nationality is a requirement to input in your product...

From your source code:

image.png

You guys check nationality based on localCount and foreignerCount.
Going back to your product's premises: "Teams comprising members entirely of a single nationality is NOT allowed"
As NUS is known for having many international students, hence classified as foreigners, even though these international students are from different nationalities, they all have to be assimilated into the foreigner category.

As such, a group made up of 5 different nationalities, e.g Chinese, Korean, American, Australian, and Vietnamese will be flagged as 0 local and 5 foreigners in your hasMixNationality method, triggering the "Group comprises of members of the same nationality." error message, which shouldn't be the case.

I tried to phrase this error as best as I could to make it sound like a typo/cosmetic error... But having to spell the bug out made me reconsider the bug's severity. This could potentially be a medium severity, as a valid group is improperly judged as erroneous. In the worse case, users might not be able to form their groups seamlessly.

As such, I propose this bug to be raised to a medium severity.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants