Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for data-analytics- [FC-3152] #2424

Open
wants to merge 62 commits into
base: master
Choose a base branch
from

Conversation

tewarig
Copy link
Contributor

@tewarig tewarig commented Nov 26, 2024

Description

this pr adds support for
data-analytics-* attribute

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: fa2fee7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 26, 2024

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Nov 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa2fee7:

Sandbox Source
razorpay/blade: basic Configuration

@tewarig tewarig changed the title Feat/add support for data analytics Feat:add support for data analytics Nov 26, 2024
@tewarig tewarig changed the title Feat:add support for data analytics Feat:add support for data-analytics-* Nov 26, 2024
@rzpcibot
Copy link
Collaborator

rzpcibot commented Nov 26, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
Accordion, AccordionItemHeader, AccordionItemBody, AccordionItem 7.556 8.112 +0.556 KB
Alert 11.391 11.686 +0.295 KB
ActionList, ActionListItem, ActionListItemAvatar, ActionListItemBadge, ActionListItemBadgeGroup, ActionListItemIcon, ActionListItemText, ActionListSection 16.328 16.563 +0.235 KB
Amount 1.275 1.374 +0.099 KB
Avatar, AvatarGroup, TrustedBadgeIcon 6.283 6.367 +0.084 KB
Badge 0.789 0.897 +0.108 KB
BladeProvider 1.710 1.712 +0.002 KB
BottomNav, BottomNavItem 0.954 1.085 +0.131 KB
BottomSheet 9.410 9.575 +0.165 KB
Box 0.774 0.869 +0.095 KB
Breadcrumb, BreadcrumbItem 2.497 2.666 +0.169 KB
ButtonGroup 1.113 1.220 +0.107 KB
Card, CardBody, CardHeader, CardHeaderIcon, CardHeaderIconButton, CardHeaderLeading, CardHeaderTrailing, CardFooter, CardFooterLeading, CardFooterTrailing 9.215 9.478 +0.263 KB
Carousel, CarouselItem 7.236 7.370 +0.134 KB
Checkbox 6.170 6.331 +0.161 KB
Chip, ChipGroup 8.435 8.628 +0.193 KB
Collapsible, CollapsibleLink, CollapsibleButton, CollapsibleBody 9.665 9.870 +0.205 KB
Counter 0.754 0.846 +0.092 KB
DatePicker 85.787 86.542 +0.755 KB
Divider 0.522 0.613 +0.091 KB
Drawer, DrawerBody, DrawerHeader, drawerPadding 16.853 17.405 +0.552 KB
Dropdown, DropdownOverlay, DropdownButton, DropdownLink, DropdownFooter, DropdownHeader 28.284 28.688 +0.404 KB
FileUpload 17.397 17.688 +0.291 KB
Indicator 1.002 1.093 +0.091 KB
List, ListItem, ListItemLink, ListItemCode, ListItemText 5.098 5.225 +0.127 KB
Menu, MenuItem, MenuOverlay, MenuDivider, MenuFooter, MenuHeader 29.074 29.544 +0.470 KB
Modal 13.113 13.281 +0.168 KB
Popover, PopoverInteractiveWrapper 21.106 21.437 +0.331 KB
ProgressBar 3.111 3.206 +0.095 KB
Radio 4.894 5.044 +0.150 KB
SideNav, SideNavLink, SideNavLevel, SideNavSection, SideNavItem, SideNavFooter, SideNavBody, SIDE_NAV_EXPANDED_L1_WIDTH_BASE, SIDE_NAV_EXPANDED_L1_WIDTH_XL 32.401 33.121 +0.720 KB
Skeleton 0.745 0.828 +0.083 KB
SpotlightPopoverTour, SpotlightPopoverTourFooter, SpotlightPopoverTourStep 29.586 29.852 +0.266 KB
StepGroup, StepItem, StepItemIcon, StepItemIndicator 6.791 6.989 +0.198 KB
Switch 4.648 4.790 +0.142 KB
Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions, TableEditableCell, TableEditableDropdownCell 66.146 66.828 +0.682 KB
Tabs, TabItem, TabList, TabPanel 7.142 7.328 +0.186 KB
Tag 3.534 3.852 +0.318 KB
ToastContainer, useToast 12.589 12.878 +0.289 KB
Tooltip, TooltipInteractiveWrapper 15.763 15.888 +0.125 KB
TopNav, TopNavActions, TopNavBrand, TopNavContent 1.177 1.288 +0.111 KB
Button 5.985 6.109 +0.124 KB
IconButton 0.845 1.108 +0.263 KB
CheckboxGroup 4.995 5.138 +0.143 KB
SelectInput, AutoComplete 36.112 36.443 +0.331 KB
OTPInput 30.072 30.250 +0.178 KB
PasswordInput 31.707 32.015 +0.308 KB
PhoneNumberInput 60.044 60.705 +0.661 KB
SearchInput 34.398 34.671 +0.273 KB
TextArea 32.234 32.514 +0.280 KB
TextInput 33.816 34.109 +0.293 KB
Link 2.115 2.201 +0.086 KB
RadioGroup 4.980 5.125 +0.145 KB
Spinner 1.795 1.888 +0.093 KB
TabNav, TabNavItems, TabNavItem 3.005 3.106 +0.101 KB
Code 0.591 0.673 +0.082 KB
Display 0.486 0.487 +0.001 KB
Heading, getHeadingProps 0.430 0.431 +0.001 KB
Text 0.003 0.004 +0.001 KB

Generated by 🚫 dangerJS against fa2fee7

@tewarig tewarig changed the title Feat:add support for data-analytics-* Feat:add support for data-analytics-*. [FC-3152] Nov 27, 2024
@tewarig tewarig changed the title Feat:add support for data-analytics-*. [FC-3152] [FC-3152] Feat:add support for data-analytics-*. Nov 27, 2024
@tewarig tewarig changed the title [FC-3152] Feat:add support for data-analytics-*. [FC-3152] ffeat:add support for data-analytics-*. Nov 28, 2024
@tewarig tewarig changed the title [FC-3152] ffeat:add support for data-analytics-*. [FC-3152] feat:add support for data-analytics-*. Nov 28, 2024
@tewarig tewarig changed the title [FC-3152] feat:add support for data-analytics-*. feat: add support for data-analytics- [FC-3152] Nov 28, 2024
@tewarig tewarig marked this pull request as ready for review November 28, 2024 05:48
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just test out once if things are working as expected for inputs, and checkbox, radio, etc correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants