Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not supporting React 18.0 #424

Open
iamromec opened this issue Nov 5, 2022 · 13 comments
Open

Not supporting React 18.0 #424

iamromec opened this issue Nov 5, 2022 · 13 comments

Comments

@iamromec
Copy link

iamromec commented Nov 5, 2022

Hello Team,

The npm package https://www.npmjs.com/package/react-native-razorpay was updated 7 months ago and currently does not support React 18.0. Please find the attached screenshot for your reference. Can you please update it so we can integrate it with the gateway account?

Screenshot 2022-11-05 at 8 31 26 PM

@vivekshindhe
Copy link
Contributor

@iamromec Fix for this and future versions, is currently in progress. It will be released tomorrow at the latest. I will update here once again when released. Just a heads up. thank you for your patience

@vivekshindhe
Copy link
Contributor

v2.3.0 is live with support for the latest versions. Thank you for your patience. Closing the ticket now

@iamromec
Copy link
Author

iamromec commented Nov 9, 2022

It seems because of the unstable plugin there are still issues with it.

As I installed the plugin, I started getting this error (FYI: I'm running it on Simulator not metro builder --- ideally it should work):

Simulator Screen Shot - iPhone 14 - 2022-11-09 at 23 43 09

There are one more error:

  • Test Key does not work at all; it throws this error

Simulator Screen Shot - iPhone 14 - 2022-11-09 at 23 50 26

Hope you guys resolve these too.

@vivekshindhe
Copy link
Contributor

vivekshindhe commented Nov 9, 2022

Hey @iamromec

The screenshot of the YGAlign error. I don't see how the razorpay package is doing that as we don't use any dependencies whatsoever. Can you try changing it to one of the values given there?

For the second, have you tested with live keys? And/or with an actual device? I tested the builds on an iOS device. Did not face any such issues but will try to reproduce them on our end.

@iamromec
Copy link
Author

iamromec commented Nov 9, 2022

The live key works fine.

Also, I'm using expo so how do we handle it during development because the app is not running after this integration? We need some way around Expo so development goes smooth.

@iamromec
Copy link
Author

iamromec commented Nov 9, 2022

This is the error with the Expo client.

Simulator Screen Shot - iPhone 14 - 2022-11-10 at 00 37 31

@vivekshindhe
Copy link
Contributor

@iamromec it's not able to access the native modules. Did you prebuild the application?

@vivekshindhe
Copy link
Contributor

For expo, i have tested this and it works completely fine for me for some reason. Can you follow the readme doc in this for expo and see if that resolves your issues?

@iamromec
Copy link
Author

@vivekshindhe could you please also answer how we handle it during development mode on Expo?

@iamromec
Copy link
Author

Hi @vivekshindhe, while running the app with expo run:ios, it's throwing the following errors:

Screenshot 2022-11-12 at 4 53 44 PM

It seems there are multiple dependency issues with the plug in as you guys have may have tested with simple or vanilla app with just react-native-razorpay plugin. But in the real world app, it has many plugins and libraries installed. Please check again and reopen the case if possible.

@vivekshindhe vivekshindhe reopened this Nov 12, 2022
@vivekshindhe
Copy link
Contributor

vivekshindhe commented Nov 12, 2022

@iamromec Reopened this. Can you share the package.json file to [email protected] so that I can try to reproduce this with those packages installed?

@iamromec
Copy link
Author

It's throwing this error sometimes:

Screenshot 2022-11-25 at 1 14 49 PM

@sandeshnaroju
Copy link

Also, is react native customui support for react 18 available? custom UI is not installable with 18 currently, kindly update that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants