-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare the test suite for the next Quarto release #21
Comments
rchaput
added a commit
that referenced
this issue
May 4, 2024
We previously used Deno, as it is embedded in Quarto (anyone can run the script); however, Deno has given us all sorts of troubles (changing the functions' names, changing imports, ...). Quarto also supports Python scripts, although the interpreter must be installed externally (but that should not be a problem, everyone has Python, and CI/CD workflows can easily setup a Python interpreter). This commit: * Removes the Deno test script `run_tests.ts`. * Replaces it with a new Python script `run_tests.py`. * Automatically detects tests to perform instead of requiring to list them in the test script (see the `all_tests` variable). * Adds information to the "short" reporting (single-line result on the command line), by indicating whether the return code is OK, the actual output equals the expected one, and the actual error equals the expected one. These details were previously only present in the Markdown summary. * Adds an argument parser to support for various arguments in the future, instead of only considering arguments to be the tests names. We can still specify the tests to run as arguments, but more options can be made available. * Update the test workflow (GitHub CI/CD) to setup Python and run the Python test script instead of the Deno one. Solves #21
rchaput
added a commit
that referenced
this issue
May 4, 2024
We previously used Deno, as it is embedded in Quarto (anyone can run the script); however, Deno has given us all sorts of troubles (changing the functions' names, changing imports, ...). Quarto also supports Python scripts, although the interpreter must be installed externally (but that should not be a problem, everyone has Python, and CI/CD workflows can easily setup a Python interpreter). This commit: * Removes the Deno test script `run_tests.ts`. * Replaces it with a new Python script `run_tests.py`. * Automatically detects tests to perform instead of requiring to list them in the test script (see the `all_tests` variable). * Adds information to the "short" reporting (single-line result on the command line), by indicating whether the return code is OK, the actual output equals the expected one, and the actual error equals the expected one. These details were previously only present in the Markdown summary. * Adds an argument parser to support for various arguments in the future, instead of only considering arguments to be the tests names. We can still specify the tests to run as arguments, but more options can be made available. * Update the test workflow (GitHub CI/CD) to setup Python and run the Python test script instead of the Deno one. Solves #21
rchaput
added a commit
that referenced
this issue
May 4, 2024
We previously used Deno, as it is embedded in Quarto (anyone can run the script); however, Deno has given us all sorts of troubles (changing the functions' names, changing imports, ...). Quarto also supports Python scripts, although the interpreter must be installed externally (but that should not be a problem, everyone has Python, and CI/CD workflows can easily setup a Python interpreter). This commit: * Removes the Deno test script `run_tests.ts`. * Replaces it with a new Python script `run_tests.py`. * Automatically detects tests to perform instead of requiring to list them in the test script (see the `all_tests` variable). * Adds information to the "short" reporting (single-line result on the command line), by indicating whether the return code is OK, the actual output equals the expected one, and the actual error equals the expected one. These details were previously only present in the Markdown summary. * Adds an argument parser to support for various arguments in the future, instead of only considering arguments to be the tests names. We can still specify the tests to run as arguments, but more options can be made available. * Update the test workflow (GitHub CI/CD) to setup Python and run the Python test script instead of the Deno one. Solves #21
rchaput
added a commit
that referenced
this issue
May 4, 2024
We previously used Deno, as it is embedded in Quarto (anyone can run the script); however, Deno has given us all sorts of troubles (changing the functions' names, changing imports, ...). Quarto also supports Python scripts, although the interpreter must be installed externally (but that should not be a problem, everyone has Python, and CI/CD workflows can easily setup a Python interpreter). This commit: * Removes the Deno test script `run_tests.ts`. * Replaces it with a new Python script `run_tests.py`. * Automatically detects tests to perform instead of requiring to list them in the test script (see the `all_tests` variable). * Adds information to the "short" reporting (single-line result on the command line), by indicating whether the return code is OK, the actual output equals the expected one, and the actual error equals the expected one. These details were previously only present in the Markdown summary. * Adds an argument parser to support for various arguments in the future, instead of only considering arguments to be the tests names. We can still specify the tests to run as arguments, but more options can be made available. * Update the test workflow (GitHub CI/CD) to setup Python and run the Python test script instead of the Deno one. Solves #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our tests fail against the "pre-release" of Quarto, because of the following error:
This is probably because the next version of Quarto embeds a new Deno version that no longer exports
writeAllSync
.Deno 2.x has indeed removed this function, see the following links for more details:
Deno has been a pain in the *** since the test suite was created. However, its big advantage is that it is embedded within Quarto, so we are certain that the script can be executed (the problem is that, depending on Deno's version, our imports might not work.....).
I see three potential alternatives:
The text was updated successfully, but these errors were encountered: