Make SimpleDateFormat usages thread-local to fix date parsing corruption #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
force-pushed
the
thread-local-simpledateformat
branch
from
cecf824
to
2b6147b
Compare
findepi
reviewed
Oct 21, 2020
json/src/main/java/org/openx/data/jsonserde/util/ThreadLocalSimpleDateFormat.java
Outdated
Show resolved
Hide resolved
SimpleDateFormat is not threadsafe since it mutates fields internally during calls to parse and format. This changes previously static instances of SimpleDateFormat into static thread-local instances to avoid the the possibility of data becoming corrupted as a result of concurrent accesses to these instances from multiple threads
pettyjamesm
force-pushed
the
thread-local-simpledateformat
branch
from
2b6147b
to
a9e2493
Compare
|
@rcongiu any update on when this can be merged in? |
|
Any updates on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleDateFormat is not threadsafe since it mutates fields internally during calls to parse and format. This changes previously static instances of SimpleDateFormat into static thread-local instances to avoid the the possibility of data becoming corrupted as a result of concurrent accesses to these instances from multiple threads.
Fixes #227