Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are the clinician / lay statements appropriate #13

Closed
eatyourpeas opened this issue Jun 5, 2020 · 9 comments
Closed

Are the clinician / lay statements appropriate #13

eatyourpeas opened this issue Jun 5, 2020 · 9 comments
Assignees
@pacharanero
Labels
design-decision An issue that documents a past, present or future design decision in the project mvp required for MVP launch question A issue that asks a question

Comments

@eatyourpeas
Copy link
Member

Child centile results are reported with a string value interpretation for the user, one as a lay message to guide families on interpretation of the centile result, while the clinician message assumes some medical knowledge and training and may make referral recommendations. Are these appropriate in each case?
@eatyourpeas eatyourpeas added question A issue that asks a question mvp required for MVP launch design-decision An issue that documents a past, present or future design decision in the project labels Jun 5, 2020
@pacharanero
Copy link
Member

pacharanero commented Jun 6, 2020 •
edited
Loading

These statements can be found here:
https://github.com/rcpch/digital-growth-charts/blob/master/rcpchgrowth/rcpchgrowth/growth_interpretations.py

@eatyourpeas there are a number of duplicated lines, and of course all the texts here are also duplicated in https://github.com/rcpch/digital-growth-charts/blob/master/README.md as well. It would be nice to refactor some of this to reduce duplication, and that also might provide an opportunity to bring in an i18n library such as gettext - which would be progress towards #4

@magdaumerska
Copy link

Thank you @eatyourpeas and @pacharanero - are you happy for me to share this file from MS Teams, with the Project Board? I believe the content is the same as above, or does it need any de-dupe?

@pacharanero
Copy link
Member

Yes that file looks to have all the same information on it. Happy for you to share that with them, and we will implement any changes they make in the code.

Please, can you ask the Project Board that if they change any of the statements, they could make it easy for us to see which have changed, by, for example, highlighting in bold and a bright text colour?

@magdaumerska
Copy link

magdaumerska commented Jun 9, 2020 •
edited
Loading

Great, thank you Marcus. I'll circulate the document now and ask the Board to feed back with tracked changes or in different font colour. I'll refer back shortly.

@statist7
Copy link
Contributor

statist7 commented Jun 9, 2020

I've just added some comments to the document, but not sure if they are saved.

@magdaumerska
Copy link

Thank you Tim - I have just checked the file on MS Teams and I can see your comments.

@pacharanero
Copy link
Member

Decision at Project Board was that these statements cannot be useful since they reflect only a single measurement, therefore they have requested that we remove them. In future we may be able to add advice statements which reflect multiple measurements, and at that stage we can re-add this.

@pacharanero
Copy link
Member

@pacharanero remove the no-longer required files

pacharanero added a commit that referenced this issue Sep 4, 2020
@pacharanero
refactor to close #13 lay and clinician comments
d1398c5 
* removed all code relating to the growth chart interpretation/advice strings, but not removed any of the decimal age and gestation age correction strings
* bugs fixed in the decimal age and genstation age comment code (as per TC review of this code during the sprint planning meeting 28.08.20)
* tidied code format to make long method/function calls multiline
* refactored `variable=functioncall(); return variable` pattern into `return functioncall()`
@pacharanero
Copy link
Member

closed by #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pacharanero pacharanero

Labels
design-decision An issue that documents a past, present or future design decision in the project mvp required for MVP launch question A issue that asks a question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eatyourpeas @pacharanero @statist7 @magdaumerska