Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display same UI to admins as normal users see #502

Open
mbarton opened this issue Jan 22, 2025 · 1 comment
Open

Display same UI to admins as normal users see #502

mbarton opened this issue Jan 22, 2025 · 1 comment
Labels
user interface Improvements or fixes here mainly to the user interface

Comments

@mbarton
Copy link
Member

mbarton commented Jan 22, 2025

At the moment as an audit team member you can edit a submission created from a CSV upload using the questionnaire. This is a deliberate design decision.

However it would be useful to still show the UI to the admin as if they were a normal user who can't. The admin can then opt in to editing via clicking an additional button etc.

This should make it less likely that we miss UI bugs in the future because we always test as admins. For example rcpch/rcpch-audit-engine#1184 in Epilepsy12.

@mbarton mbarton added the user interface Improvements or fixes here mainly to the user interface label Jan 22, 2025
@mbarton mbarton changed the title Display same UI to normal users and admins Display same UI to admins as normal users see Jan 22, 2025
@mbarton
Copy link
Member Author

mbarton commented Jan 22, 2025

Interestingly I tried this on staging and I correctly can't edit the visits. Not sure what's different between the setup on staging vs what I have locally.

Either way we should say explicitly why the fields are disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user interface Improvements or fixes here mainly to the user interface
Projects
None yet
Development

No branches or pull requests

1 participant