You can set HBA1c and blood pressure dates without values

[mbarton]

We should probably flag this as a validation error for both CSV uploads and the questionnaire?

[eatyourpeas]

This I think is important having played with it. Each question is atomic (eg weight should also have a date) and should trigger a validation error if not all of the elements of the question are supplied. Our validations have been too permissive and should flag if a question is incomplete.
It is also possible to save a visit without a date which feels to me also a never event.

[mbarton]

It is also possible to save a visit without a date which feels to me also a never event.

Ah thanks, I was going to raise an issue for that but I wasn't sure whether it should be supported for adding some of the fields that are not filled in on every visit

[eatyourpeas]

So this is something that has puzzled me from the start actually. There are dates for some measures but not for others, which is fine but it means that it is possible to submit for example a coeliac screen result and it's date but forget to fill the visit date. It is designed the way it is though because children come to clinic and that is the place and time decisions are made. The dates for the other things are there because it is recognized that these things often don't always happen in clinic. The visit though really only has the visit date as the closest to a unique ID. So the options we have are:

1. Allow the visit to be saved without a date
2. fill the date automatically if not supplied with the current date
3. Prevent the form being submitted without a visit date (as we do with the csv upload)

My preference is for option 3. What do we reckon?

[eatyourpeas]

I think this is now fixed. Can I check @mbarton there is nothing further here to do from your point of view?