Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The HSTS config for trunk.rdoproject.org overrides *.rdoproject.org #40

Open
dmsimard opened this issue Jul 26, 2016 · 5 comments
Open
Assignees

Comments

@dmsimard
Copy link
Contributor

How to reproduce:

  1. Clear HSTS config for rdoproject.org (i.e, in chrome chrome://net-internals/#hsts)
  2. Visit something that is http only ( status.rdoproject.org or uchiwa.monitoring.rdoproject.org )
  3. Visit trunk.rdoproject.org
  4. Visit something from step 2

Now.. we could argue that everything under rdoproject.org should be SSL, but it's probably not a decision that should be made by trunk.rdoproject.org :)

@apevec
Copy link
Member

apevec commented Jul 27, 2016

Where is that configured in httpd config?
@javierpena @dmsimard afaict HSTS[1] is not configured on trunk.rdoproject.org, there isn't Strict-Transport-Security: header in response and http: is not redirecting to https: ?

[1] https://www.owasp.org/index.php/HTTP_Strict_Transport_Security_Cheat_Sheet

@apevec
Copy link
Member

apevec commented Jul 27, 2016

From bash history I see @javierpena used puppet apache module to configure httpd, so leaving this one for him.
And here is the manifest where SSL is enabled: https://github.com/rdo-infra/puppet-dlrn/blob/master/manifests/web.pp#L67

@javierpena
Copy link
Contributor

I think the HSTS header is defined in rdoproject.org rather than trunk.rdoproject.org.

Using a Firefox extension, I've seen that anytime we fetch the CSS content from rdoproject.org, we get the Strict-Transport-Security header. Since the CSS is loaded by the front page, we get the HSTS content.

Just tried the reproduction steps using http://trunk.rdoproject.org/centos7/report.html instead of the front page, and no HSTS is enforced.

@mscherer
Copy link
Collaborator

mscherer commented Aug 1, 2016

yeah, that's set on rdoproject.org.

@dmsimard
Copy link
Contributor Author

dmsimard commented Aug 1, 2016

That's interesting because visiting rdoproject.org doesn't generate the problem for me, just trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants