From 0f800350530f84af95d823187e6697a4990b7d59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Sat, 14 Mar 2020 17:51:32 +0100 Subject: [PATCH] chore: revert "fix: Metro Bundler crashing on `run-android` on Windows (#489)" (#1052) --- .../src/commands/runAndroid/index.ts | 24 ------------------- 1 file changed, 24 deletions(-) diff --git a/packages/platform-android/src/commands/runAndroid/index.ts b/packages/platform-android/src/commands/runAndroid/index.ts index c9375608d..8aabb747a 100644 --- a/packages/platform-android/src/commands/runAndroid/index.ts +++ b/packages/platform-android/src/commands/runAndroid/index.ts @@ -315,24 +315,6 @@ function startServerInNewWindow( ? `set RCT_METRO_PORT=${port}` : `export RCT_METRO_PORT=${port}`; - /** - * Quick & temporary fix for packager crashing on Windows due to using removed --projectRoot flag - * in script. So we just replace the contents of the script with the fixed version. This should be - * removed when PR #25517 on RN Repo gets approved and a new RN version is released. - */ - const launchPackagerScriptContent = `:: Copyright (c) Facebook, Inc. and its affiliates. - :: - :: This source code is licensed under the MIT license found in the - :: LICENSE file in the root directory of this source tree. - - @echo off - title Metro Bundler - call .packager.bat - cd ../../../ - node "%~dp0..\\cli.js" start - pause - exit`; - /** * Set up the `.packager.(env|bat)` file to ensure the packager starts on the right port. */ @@ -380,12 +362,6 @@ function startServerInNewWindow( } } if (/^win/.test(process.platform)) { - //Temporary fix for #484. See comment on line 254 - fs.writeFileSync(launchPackagerScript, launchPackagerScriptContent, { - encoding: 'utf8', - flag: 'w', - }); - // Awaiting this causes the CLI to hang indefinitely, so this must execute without await. return execa('cmd.exe', ['/C', launchPackagerScript], { ...procConfig,