-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Able to build ios app but unable to get build settings to deplou #2383
Comments
hey @ToyboxZach did you resolve your issue? |
Nope, and still no idea where to even go with breaking this down |
@ToyboxZach that's really strange! Please make sure that version of |
Thanks, I’ll try that, the weird thing is the build is working just fine, it’s just the ability to grab the build settings that seems to be weird. |
hey @ToyboxZach @szymonrybczak were you able to solve this issue? I have tried already everything: upgrading OS, reinstalling Xcode but no luck. Also, |
Yes I believe all my versions match, both are 15.4 And the build is completely fine, I can even launch the binary, its explicitly failing to launch because the tool is failing to get the build settings for some reason, even though the build settings look pretty valid to me. |
it worked perfectly for me by following @chrishanthmathew91 recommendation:
Thanks! |
That is not my problem, as I don't have a React target in my build section I only have my two Targets for the two different skus of my app + the Pods target |
@chrishanthmathew91 @pvev btw if you have any troubles with targets selection logic you can also set it manually by specific @ToyboxZach please provide more information, such as |
I've been facing the same issue, so based on @szymonrybczak's message, I applied a patch with the following diff, which fixed the issue on my end: diff --git a/build/commands/runCommand/getBuildSettings.js b/build/commands/runCommand/getBuildSettings.js
index 8e60c59cba33029e1a1e27129c31eee45207fe58..cae01ad81a08d401ae1d2a06861471a0a465fd4f 100644
--- a/build/commands/runCommand/getBuildSettings.js
+++ b/build/commands/runCommand/getBuildSettings.js
@@ -31,10 +31,16 @@ async function getBuildSettings(xcodeProject, mode, buildOutput, scheme, target)
encoding: 'utf8'
});
const settings = JSON.parse(buildSettings);
+ const fistIndexForAppTarget = Math.max(
+ 0,
+ settings.findIndex(({
+ buildSettings: bs
+ }) => bs.WRAPPER_EXTENSION === 'app'),
+ );
const targets = settings.map(({
target: settingsTarget
}) => settingsTarget);
- let selectedTarget = targets[0];
+ let selectedTarget = targets[fistIndexForAppTarget];
if (target) {
if (!targets.includes(target)) {
_cliTools().logger.info(`Target ${_chalk().default.bold(target)} not found for scheme ${_chalk().default.bold(scheme)}, automatically selected target ${_chalk().default.bold(selectedTarget)}`); |
What appears to be the same issue but a slightly different error. The app builds but fails to find the correct target and doesn't install. Works perfectly when build and installed from XCode. The error is failed to get the target build directory as seen here : `node:internal/process/promises:289 [UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Error: Failed to get the target build directory.".] { Tracked the error down to getBuildPath here ... As suggested above, removing the React target seems to resolve the issue but obviously isn't ideal. React native 0.73.8 |
Environment
System:
OS: macOS 14.4.1
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 2.12 GB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.10.0
path: /usr/local/bin/node
Yarn:
version: 1.22.21
path: /usr/local/bin/yarn
npm:
version: 10.7.0
path: ~/toybox/app/node_modules/.bin/npm
Watchman:
version: 2023.12.04.00
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.15.2
path: /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.4
- iOS 17.4
- macOS 14.4
- tvOS 17.4
- visionOS 1.1
- watchOS 10.4
Android SDK:
Android NDK: 22.1.7171670
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10406996
Xcode:
version: 15.3/15E204a
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.10
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Description
I am able to consistently build the app and get good out put, but the command line tool never is able to deploy it.
I have gone into the built direct and done xcrun on my simulator so I know the generated binary is completely fine.
I dove into this package to figure out why it was unable to get the build settings and I'm able to mimic what I expect this line to be doing:
And I get relatively valid results
This is the output I get:
Reproducible Demo
I don't know how to get this down into an easily reproducible situation, but at a minimum it feels like there is a bunch of missing logging or information as the actual errors don't make any sense.
If anyone has suggestions for a fix or cause I can try to break it down further (I have done all the suggested stack overflow answers)
The text was updated successfully, but these errors were encountered: