Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promotion enhancement #206

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Promotion enhancement #206

merged 4 commits into from
Aug 7, 2023

Conversation

vannguyenn
Copy link
Collaborator

@vannguyenn vannguyenn commented Feb 24, 2023 •
edited
Loading

Resolves #185 #187

  • Updated react-router-dom library and improve tests

Testing Instructions:

  • Use branch feat/promotions on API
  • Start the app and login with a valid account
  • Navigate to Promotions
  • Click Actions/Create New
  • Fill in any fields in the form
  • Navigate to another page, reload or close the window

Screenshot 2023-02-24 at 10 36 29

Screenshot 2023-02-24 at 10 36 17

@vannguyenn vannguyenn marked this pull request as ready for review February 24, 2023 03:22
@vannguyenn vannguyenn changed the title Feat/upgrade react router Promotion enhancement Feb 24, 2023
brent-hoover
brent-hoover approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised

@tedraykov tedraykov merged commit 6d427c2 into trunk Aug 7, 2023
@tedraykov tedraykov deleted the feat/upgrade-react-router branch August 7, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedraykov tedraykov tedraykov approved these changes

@brent-hoover brent-hoover brent-hoover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promotions: prompt user if unsaved changes exist
3 participants
@vannguyenn @brent-hoover @tedraykov