From 5deab02dd4a762320061e84964b5a0da3f149a8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micka=C3=ABl=20Menu?= <mickael.menu@gmail.com> Date: Mon, 4 Nov 2024 15:27:59 +0100 Subject: [PATCH] Add a couple of references --- gradle.properties | 3 +++ readium/lcp/build.gradle.kts | 1 + readium/navigator/build.gradle.kts | 1 + readium/shared/src/main/java/org/readium/r2/shared/util/Url.kt | 1 - 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gradle.properties b/gradle.properties index 48a7a7d383..dd882096fb 100644 --- a/gradle.properties +++ b/gradle.properties @@ -27,4 +27,7 @@ android.useAndroidX=true android.enableJetifier=true # Kotlin code style for this project: "official" or "obsolete": kotlin.code.style=official + +# FIXME: There are still a few issues with KSP and K2. It probably won't be ready until Room is +# updated to 2.7.0 (currently in alpha), and the KSP2 issue with @TypeConverters is fixed. #ksp.useKSP2=true diff --git a/readium/lcp/build.gradle.kts b/readium/lcp/build.gradle.kts index d69ded657a..f0dd3a6f49 100644 --- a/readium/lcp/build.gradle.kts +++ b/readium/lcp/build.gradle.kts @@ -13,6 +13,7 @@ android { namespace = "org.readium.r2.lcp" kotlinOptions { + // See https://github.com/readium/kotlin-toolkit/pull/525#issuecomment-2300084041 freeCompilerArgs = freeCompilerArgs + ("-Xconsistent-data-class-copy-visibility") } } diff --git a/readium/navigator/build.gradle.kts b/readium/navigator/build.gradle.kts index 141eb18371..013535d3d1 100644 --- a/readium/navigator/build.gradle.kts +++ b/readium/navigator/build.gradle.kts @@ -17,6 +17,7 @@ android { } kotlinOptions { + // See https://github.com/readium/kotlin-toolkit/pull/525#issuecomment-2300084041 freeCompilerArgs = freeCompilerArgs + ("-Xconsistent-data-class-copy-visibility") } } diff --git a/readium/shared/src/main/java/org/readium/r2/shared/util/Url.kt b/readium/shared/src/main/java/org/readium/r2/shared/util/Url.kt index c54bb17fb7..4cc174133f 100644 --- a/readium/shared/src/main/java/org/readium/r2/shared/util/Url.kt +++ b/readium/shared/src/main/java/org/readium/r2/shared/util/Url.kt @@ -205,7 +205,6 @@ public sealed class Url : Parcelable { * WARNING: Strict URL comparisons can be a source of bug, if the URLs are not normalized. * In most cases, you should compare using [Url.isEquivalent]. */ -// @DelicateReadiumApi override fun equals(other: Any?): Boolean { if (this === other) return true if (javaClass != other?.javaClass) return false