New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache CRL (Certificate Revocation List)? #5

Open

danielweck opened this issue Aug 29, 2019 · 0 comments

Member

danielweck commented Aug 29, 2019

HTTP timeout / latency can create bad UX, but how to ensure CRL is most up to date, when actually needed?

r2-lcp-js/src/parser/epub/lcp.ts

Line 233 in ea54bf5

const crlPem = await this.getCRLPem();

=>

r2-lcp-js/src/parser/epub/lcp.ts

Line 316 in ea54bf5

private async getCRLPem(): Promise<string> {

Note the "dummy" empty CRL used as fallback:

r2-lcp-js/src/parser/epub/lcp-certificate.ts

Line 16 in ea54bf5

export const DUMMY_CRL = `-----BEGIN X509 CRL-----

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment