Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRU Least Recently Used caching strategy #47

Open
danielweck opened this issue Jul 1, 2019 · 0 comments
Open

LRU Least Recently Used caching strategy #47

danielweck opened this issue Jul 1, 2019 · 0 comments

Comments

@danielweck
Copy link
Member

This "TODO" code comment has been present from day-1 in the TypeScript source, still unresolved (time to file an issue!):

public cachePublication(filePath: string, pub: Publication) {
// TODO: implement LRU caching algorithm? Anything smarter than this will do!
if (!this.isPublicationCached(filePath)) {
this.pathPublicationMap[filePath] = pub;
}
}

Basically, the cache of ReadiumWebPubManifest models grows indefinitely in the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant