Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File tree diff: cache diff result #11695

Open
stsewd opened this issue Oct 17, 2024 · 0 comments
Open

File tree diff: cache diff result #11695

stsewd opened this issue Oct 17, 2024 · 0 comments
Labels
Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Oct 17, 2024

What's the problem this feature will solve?

Since we are using just some sets operations over the files to get the diff, I don't think the operation itself is expensive. Probably it takes more time to fetch the manifests from storage.

Describe the solution you'd like

We can cache the result, probably this isn't relevant to .org, since the response from the addons is always cached. On .com we could cache the result so it's relevant for private docs.

Alternative solutions

Do nothing, getting the diff should be fast enough?

Additional context

#11646

@stsewd stsewd added the Needed: design decision A core team decision is required label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

1 participant