Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add startTransition #838

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

r17x
Copy link
Contributor

@r17x r17x commented Jun 7, 2024

@davesnx davesnx merged commit ecccd3c into reasonml:main Jul 17, 2024
0 of 3 checks passed
@davesnx
Copy link
Member

davesnx commented Jul 17, 2024

Thanks @r17x

davesnx added a commit that referenced this pull request Jul 17, 2024
* 'main' of github.com:/reasonml/reason-react:
  feat(react): add startTransition (#838)
  feat(react): add isValidElement (#837)
davesnx added a commit that referenced this pull request Jul 17, 2024
…prop

* 'main' of github.com:/reasonml/reason-react:
  Add CSS Box Alignment Module Level 3 (#847)
  Remove type callback duplicate
  feat(react): add startTransition (#838)
  feat(react): add isValidElement (#837)
@@ -872,10 +872,15 @@ module Uncurried = {
"useCallback";
};

type callback('input, 'output) = 'input => 'output;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already defined in line 471

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw 757dd23

Copy link
Contributor Author

@r17x r17x Jul 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for confusing @anmonteiro, I should have PASSED Pipelines before merge this PR.

jchavarri added a commit to jchavarri/opam-repository that referenced this pull request Aug 19, 2024
CHANGES:

* Add `isValidElement` (@r17x in
  reasonml/reason-react#837)
* Add `startTransition` (@r17x in
  reasonml/reason-react#838)
* Convert `ReasonReactErrorBoundary` to Reason instead of `%raw` JS. This has
  the benefit of skipping a hardcoded `require('react')` call (@anmonteiro in
  [reasonml/reason-react#839](reasonml/reason-react#839))
* Add CSS Box Alignment Module Level 3 (@davesnx in
  reasonml/reason-react#847)
* Fix: Remove "unique `key` prop" warnings from multi-child fragment elements
  (@jchavarri in reasonml/reason-react#852)
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
CHANGES:

* Add `isValidElement` (@r17x in
  reasonml/reason-react#837)
* Add `startTransition` (@r17x in
  reasonml/reason-react#838)
* Convert `ReasonReactErrorBoundary` to Reason instead of `%raw` JS. This has
  the benefit of skipping a hardcoded `require('react')` call (@anmonteiro in
  [reasonml/reason-react#839](reasonml/reason-react#839))
* Add CSS Box Alignment Module Level 3 (@davesnx in
  reasonml/reason-react#847)
* Fix: Remove "unique `key` prop" warnings from multi-child fragment elements
  (@jchavarri in reasonml/reason-react#852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants