Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract stash package #591

Open
mamachanko opened this issue Feb 10, 2025 · 2 comments
Open

Extract stash package #591

mamachanko opened this issue Feb 10, 2025 · 2 comments

Comments

@mamachanko
Copy link
Contributor

The reconcilers package is large. We would like to extract everything related to stashing into a stash package.

We don't want to break anyone's code. That means we'd like to alias the types in the reconcilers package for backwards-compatibility.

⚡ Some of the types, most prominently Stasher are generic. However, generic types cannot be aliased unless GOEXPERIMENT=aliastypeparams is set or until runtime depends on Go 1.24 (see alias names). That means this is blocked until Go 1.24 is out and we require it.

validation.WithRecursive can start using a Stasher then.

@mamachanko
Copy link
Contributor Author

Go 1.24 is out with generic type aliases.

@scothis
Copy link
Member

scothis commented Feb 13, 2025

This will probably be actionable in 6 months once k8s bumps to require go 1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants