feat add event handlers to make request async #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasmiller
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Thank you for creating the pull request @aron-ridgway-deltatre!
recurly-integrations
pushed a commit
that referenced
this pull request
Jan 18, 2024
[Full Changelog](4.47.0...4.48.0) **Merged Pull Requests** - Generated Latest Changes for v2021-02-25 [#812](#812) ([recurly-integrations](https://github.com/recurly-integrations)) - feat add event handlers to make request async [#811](#811) ([aron-ridgway-deltatre](https://github.com/aron-ridgway-deltatre))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue we are facing
The issue we are facing is we have a multi tenant application and we need to add tracing/monitoring for Recurly http calls per tenant, so we can monitor the amount off calls being made by each tenant which include paged requests that happen in the background.
BaseClient MakeRequest has Event handlers which can be used to hook into http request and responses.
MakeRequestAsync that we use in our service is currently missing the Event Handling processing,
Proposed solution
Add the event handling logic to the MakeRequestAsync method.
There may be a better way to solve this issue, so we are open to your suggestions on the best implementation to resolve this issue.