Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

提几个bug #1

Open
bajins opened this issue Dec 23, 2019 · 1 comment
Open

提几个bug #1

bajins opened this issue Dec 23, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bajins
Copy link

bajins commented Dec 23, 2019

1、修复英文状态下字母显示溢出
https://github.com/redblue9771/minibarrage/blob/16eef062b8089c31dd96e026012435f946071bb7/pages/index/index.wxss#L16

line-height: 0.85;

2、增加文字间距
https://github.com/redblue9771/minibarrage/blob/16eef062b8089c31dd96e026012435f946071bb7/pages/index/index.wxss#L19

letter-spacing:50px;

3、修复当改变速度时,原有的按钮颜色没有消失

https://github.com/redblue9771/minibarrage/blob/16eef062b8089c31dd96e026012435f946071bb7/pages/index/index.js#L128

let speedArray = [];
for (let i = 0; i < this.data.speedArr.length; i++) {
  let active = false;
  if (i == newIndex) {
    active = true;
  }
  speedArray.push({
    name: this.data.speedArr[i].name,
    value: this.data.speedArr[i].value,
    active: active
  });
}

4、修复当改变字体大小时,原有的按钮颜色没有消失
https://github.com/redblue9771/minibarrage/blob/16eef062b8089c31dd96e026012435f946071bb7/pages/index/index.js#L149

let sizeArray = [];
for (let i = 0; i < this.data.sizeArr.length; i++) {
  let active = false;
  if (i == newIndex) {
    active = true;
  }
  sizeArray.push({
    name: this.data.sizeArr[i].name,
    value: this.data.sizeArr[i].value,
    active: active
  });
}
@redblue9771
Copy link
Owner

1、修复英文状态下字母显示溢出
https://github.com/redblue9771/minibarrage/blob/16eef062b8089c31dd96e026012435f946071bb7/pages/index/index.wxss#L16

line-height: 0.85;

2、增加文字间距
https://github.com/redblue9771/minibarrage/blob/16eef062b8089c31dd96e026012435f946071bb7/pages/index/index.wxss#L19

letter-spacing:50px;

3、修复当改变速度时,原有的按钮颜色没有消失

https://github.com/redblue9771/minibarrage/blob/16eef062b8089c31dd96e026012435f946071bb7/pages/index/index.js#L128

let speedArray = [];
for (let i = 0; i < this.data.speedArr.length; i++) {
  let active = false;
  if (i == newIndex) {
    active = true;
  }
  speedArray.push({
    name: this.data.speedArr[i].name,
    value: this.data.speedArr[i].value,
    active: active
  });
}

4、修复当改变字体大小时,原有的按钮颜色没有消失
https://github.com/redblue9771/minibarrage/blob/16eef062b8089c31dd96e026012435f946071bb7/pages/index/index.js#L149

let sizeArray = [];
for (let i = 0; i < this.data.sizeArr.length; i++) {
  let active = false;
  if (i == newIndex) {
    active = true;
  }
  sizeArray.push({
    name: this.data.sizeArr[i].name,
    value: this.data.sizeArr[i].value,
    active: active
  });
}

啊,不好意思,我居然现在才看到,可能什么时候清理GitHub的消息被我全选了吧。

本来只是想用SVG改写的,一直没弄,不过很感谢你找的这些缺点✨

@redblue9771 redblue9771 added good first issue Good for newcomers bug Something isn't working labels Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants