Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHTAP-1873): Remove alerts as GitOps Service is deprecated and being removed #179

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jan 23, 2024

This PR removes all of the GitOps Service alert rules/tests, as the GitOps Service is deprecated and will be removed shortly.

@amisstea
Copy link
Collaborator

@jgwest do you plan to remove the SLO dashboard visualizations in another PR?

Also, here are the gitlint errors causing the pipeline to fail:

[run-gitlint] 1: CC1 Body does not contain a 'Signed-off-by' line
[run-gitlint] 1: CT1 Title does not follow ConventionalCommits.org format 'type(optional-scope): description': "Remove alerts as GitOps Service is deprecated and being removed"
[run-gitlint] 3: B6 Body message is missing

Remove the Alerts that are related to the now deprecated GitOps Service

Signed-off-by: Jonathan West <[email protected]>
@jgwest jgwest force-pushed the remove-gitops-metrics branch from 3827450 to 77302c1 Compare January 25, 2024 23:52
@jgwest
Copy link
Member Author

jgwest commented Jan 26, 2024

Thanks @amisstea, I have fixed the git lint flags, and yes I will open a separate PR for the dashboard. (The dashboard is its own can of worms)

@jgwest
Copy link
Member Author

jgwest commented Jan 26, 2024

PR for dashboards: #184

@amisstea amisstea merged commit 38b622d into redhat-appstudio:main Jan 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants