add env vars declarations and comments for Image Registry user/pw #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can set IMAGE_REGISTRY_USER and IMAGE_REGISTRY_PASSWORD, for any registry For compatibility user can set the QUAY,NEXUS,ARTIFACTORY versions to detect. QE can set all three and detect which one to use in test. Note, for Jenkins as a global var,using IMAGE_REGISTRY_USER means means the pipelines can only use one registry. Gitlab injects all variables so define IMAGE_REGISTRY_USER and PASSWORD or leave it as the QUAY,NEXUS,ARTIFACTORY and it will work. Github uses the IMAGE_REGISTRY_USER and PASSWORD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Jenkins and Github pipeline declarations to enable used to know which vars to use for the registry. The optional vars are inserted as comments.
Users can set IMAGE_REGISTRY_USER and IMAGE_REGISTRY_PASSWORD, for any registry.
For compatibility user can set the QUAY,NEXUS,ARTIFACTORY versions to detect. QE can set all three and detect which one to use in test.
Note, for Jenkins as a global var,using IMAGE_REGISTRY_USER means means the pipelines can only use one registry.
Gitlab injects all variables so define IMAGE_REGISTRY_USER and PASSWORD or QUAY,NEXUS,ARTIFACTORY versions and it will work.
Github uses the IMAGE_REGISTRY_USER and PASSWORD