Adding homepage for dog owner #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OfirMatasas
force-pushed
the
dog-owner-homepage
branch
7 times, most recently
from
8e889d8 to
d01c7e8
Compare
tamirmatok
force-pushed
the
dog-owner-homepage
branch
4 times, most recently
from
63ee536 to
73b35d9
Compare
|
ping |
OfirMatasas
force-pushed
the
dog-owner-homepage
branch
from
73b35d9 to
b378f4f
Compare
OfirMatasas
requested review from
Omeramsc,
tamirmatok,
jeniaSakirko,
ErezCohenn,
ormergi and
Yuval-Vino
ErezCohenn
reviewed
Apr 21, 2022
tamirmatok
reviewed
Apr 22, 2022
Omeramsc
reviewed
Apr 24, 2022
Omeramsc
reviewed
Apr 24, 2022
OfirMatasas
force-pushed
the
dog-owner-homepage
branch
2 times, most recently
from
e640936 to
3101ad5
Compare
Omeramsc
reviewed
Apr 26, 2022
Omeramsc
reviewed
Apr 26, 2022
Omeramsc
reviewed
Apr 26, 2022
Omeramsc
reviewed
Apr 26, 2022
OfirMatasas
force-pushed
the
dog-owner-homepage
branch
from
3101ad5 to
750c757
Compare
5 tasks
OfirMatasas
force-pushed
the
dog-owner-homepage
branch
3 times, most recently
from
9bcb065 to
5282a31
Compare
OfirMatasas
force-pushed
the
dog-owner-homepage
branch
from
5282a31 to
fd106bd
Compare
tamirmatok
force-pushed
the
dog-owner-homepage
branch
2 times, most recently
from
a853be2 to
2f16f00
Compare
Yuval-Vino
reviewed
May 2, 2022
OfirMatasas
force-pushed
the
dog-owner-homepage
branch
from
2f16f00 to
705f393
Compare
When the dog owner is logged in to Hotails, or when the home is pressed via navbar, All the daycares in the database will be shown to the dog owner on its homepage, with the possibility to check their profile. If the daycare doesn't have any profile picture, a default one will be presented. Signed-off-by: Ofir Matasas <[email protected]> Signed-off-by: tamirmatok <[email protected]>
OfirMatasas
force-pushed
the
dog-owner-homepage
branch
from
705f393 to
a05e08b
Compare
Omeramsc
reviewed
May 4, 2022
| client.force_login(user=create_dog_owner_user.user) | ||
| response = client.get("/homepage/") | ||
| assert response.status_code == 200 | ||
| assert list(response.context['daycares']) == list(DayCare.objects.all()) |
There was a problem hiding this comment.
I want this PR merged ASAP, so please open a ticket to: assign both sides of the assertion equation to variables, then assert between the variables. it will improve the readability of the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
After the dog owner user is logged in to the website, he moved to the homepage of the site.
The homepage is the first page that the user exposed after login (or after clicking the Hotails logo on the navbar), where the dog owner can see all the daycares registered to Hotails, and check their profile for more actions.
Implemented Changes
Creating homepage only for dog owners, if another types of users will try to reach this site the will redirect back to the login page.
Connected Issue/Story
closes #66
Definition of Done
Arrange the URL patterns in Hotails and main apps
Develop logic functionality for dog owner users
Add a UI for visualization to logical implementations testing
Test coverage
This PR includes new unit and integration tests to go with the code changes